From 0097ab4c67972ae169cc0613a6c7aae72fbacfea Mon Sep 17 00:00:00 2001
From: Brian Rower <brian.rower@gmail.com>
Date: Tue, 12 Sep 2017 23:41:12 -0700
Subject: [PATCH] Improve code coverage

---
 .../test_dynamodb_table_with_range_key.py     | 32 +++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/tests/test_dynamodb2/test_dynamodb_table_with_range_key.py b/tests/test_dynamodb2/test_dynamodb_table_with_range_key.py
index 1ab25dc7a..a9ab298b7 100644
--- a/tests/test_dynamodb2/test_dynamodb_table_with_range_key.py
+++ b/tests/test_dynamodb2/test_dynamodb_table_with_range_key.py
@@ -1470,6 +1470,22 @@ def test_update_item_add_with_expression():
     ).should.have.raised(ClientError)
     dict(table.get_item(Key=item_key)['Item']).should.equal(current_item)
 
+    # Attempt to update with a bad expression
+    table.update_item.when.called_with(
+        Key=item_key,
+        UpdateExpression='ADD str_set bad_value'
+    ).should.have.raised(ClientError)
+
+    # Attempt to add a string value instead of a string set
+    table.update_item.when.called_with(
+        Key=item_key,
+        UpdateExpression='ADD str_set :v',
+        ExpressionAttributeValues={
+            ':v': 'new_string'
+        }
+    ).should.have.raised(ClientError)
+
+
 @mock_dynamodb2
 def test_update_item_delete_with_expression():
     table = _create_table_with_range_key()
@@ -1518,6 +1534,22 @@ def test_update_item_delete_with_expression():
     ).should.have.raised(ClientError)
     dict(table.get_item(Key=item_key)['Item']).should.equal(current_item)
 
+    # Try to delete a string set from a number set
+    table.update_item.when.called_with(
+        Key=item_key,
+        UpdateExpression='DELETE num_set :v',
+        ExpressionAttributeValues={
+            ':v': {'del_str'}
+        }
+    ).should.have.raised(ClientError)
+    dict(table.get_item(Key=item_key)['Item']).should.equal(current_item)
+
+    # Attempt to update with a bad expression
+    table.update_item.when.called_with(
+        Key=item_key,
+        UpdateExpression='DELETE num_val badvalue'
+    ).should.have.raised(ClientError)
+
 
 @mock_dynamodb2
 def test_boto3_query_gsi_range_comparison():