Yasuke/moto
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Idempotent Dynamodb2 deletes

Browse Source 
Fixes #873
This commit is contained in:
Jack Danger Canty 2017-05-01 12:31:31 -07:00
parent df84675ae6
commit 02edc6fa00
2 changed files with 7 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
moto/dynamodb2/responses.py
View File

@ -419,16 +419,12 @@ class DynamoHandler(BaseResponse):
keys = self.body['Key'] keys = self.body['Key']
return_values = self.body.get('ReturnValues', '') return_values = self.body.get('ReturnValues', '')
item = dynamodb_backend2.delete_item(name, keys) item = dynamodb_backend2.delete_item(name, keys)
if item: if item and return_values == 'ALL_OLD':
if return_values == 'ALL_OLD':
item_dict = item.to_json() item_dict = item.to_json()
else: else:
item_dict = {'Attributes': {}} item_dict = {'Attributes': {}}
item_dict['ConsumedCapacityUnits'] = 0.5 item_dict['ConsumedCapacityUnits'] = 0.5
return dynamo_json_dump(item_dict) return dynamo_json_dump(item_dict)
else:
er = 'com.amazonaws.dynamodb.v20120810#ConditionalCheckFailedException'
return self.error(er)
def update_item(self): def update_item(self):
name = self.body['TableName'] name = self.body['TableName']

3
tests/test_dynamodb2/test_dynamodb_table_with_range_key.py
View File

@ -314,7 +314,8 @@ def test_delete_item():
response.should.equal(True) response.should.equal(True)
table.count().should.equal(0) table.count().should.equal(0)
item.delete().should.equal(False) # Deletes are idempotent
item.delete().should.equal(True)
@requires_boto_gte("2.9") @requires_boto_gte("2.9")