Yasuke/moto
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #2780 from heyderpd/master

Browse Source 
fixing error when _get_default return value that already exists, on _get_appended_list
This commit is contained in:
Bert Blommers 2020-03-06 08:38:49 +00:00 committed by GitHub
commit 03164e7b60
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 28 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
moto/dynamodb2/models.py
View File

@ -450,9 +450,9 @@ class Item(BaseModel):
old_list_key = list_append_re.group(1) old_list_key = list_append_re.group(1)
# old_key could be a function itself (if_not_exists) # old_key could be a function itself (if_not_exists)
if old_list_key.startswith("if_not_exists"): if old_list_key.startswith("if_not_exists"):
old_list = DynamoType( old_list = self._get_default(old_list_key)
expression_attribute_values[self._get_default(old_list_key)] if not isinstance(old_list, DynamoType):
) old_list = DynamoType(expression_attribute_values[old_list])
else: else:
old_list = self.attrs[old_list_key.split(".")[0]] old_list = self.attrs[old_list_key.split(".")[0]]
if "." in old_list_key: if "." in old_list_key:

25
tests/test_dynamodb2/test_dynamodb.py
View File

@ -3634,6 +3634,31 @@ def test_update_supports_list_append_with_nested_if_not_exists_operation():
) )
@mock_dynamodb2
def test_update_supports_list_append_with_nested_if_not_exists_operation_and_property_already_exists():
dynamo = boto3.resource("dynamodb", region_name="us-west-1")
table_name = "test"
dynamo.create_table(
TableName=table_name,
AttributeDefinitions=[{"AttributeName": "Id", "AttributeType": "S"}],
KeySchema=[{"AttributeName": "Id", "KeyType": "HASH"}],
ProvisionedThroughput={"ReadCapacityUnits": 20, "WriteCapacityUnits": 20},
)
table = dynamo.Table(table_name)
table.put_item(Item={"Id": "item-id", "event_history": ["other_value"]})
table.update_item(
Key={"Id": "item-id"},
UpdateExpression="SET event_history = list_append(if_not_exists(event_history, :empty_list), :new_value)",
ExpressionAttributeValues={":empty_list": [], ":new_value": ["some_value"]},
)
table.get_item(Key={"Id": "item-id"})["Item"].should.equal(
{"Id": "item-id", "event_history": ["other_value", "some_value"]}
)
@mock_dynamodb2 @mock_dynamodb2
def test_update_catches_invalid_list_append_operation(): def test_update_catches_invalid_list_append_operation():
client = boto3.client("dynamodb", region_name="us-east-1") client = boto3.client("dynamodb", region_name="us-east-1")