Yasuke/moto
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

adding physical_resource_id in SubnetRouteTableAssociation, Route and NatGW classes (#3789)

Browse Source 
* adding physical_resource_id in SubnetRouteTableAssociation, Route and NatGW classes

* adding tests

* passing litern at test

* passsing black==19.10b0 as lintern

* passing test to python 2.7
This commit is contained in:
Ismael Fernandez Molina 2021-03-20 09:57:53 +01:00 committed by GitHub
parent a5fc99c9af
commit 04cbd1fa1a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 23 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
moto/ec2/models.py
View File

@ -4030,6 +4030,10 @@ class SubnetRouteTableAssociation(CloudFormationModel):
self.route_table_id = route_table_id
self.subnet_id = subnet_id
@property
def physical_resource_id(self):
return self.route_table_id
@staticmethod
def cloudformation_name_type():
return None
@ -4254,6 +4258,10 @@ class Route(CloudFormationModel):
self.interface = interface
self.vpc_pcx = vpc_pcx
@property
def physical_resource_id(self):
return self.id
@staticmethod
def cloudformation_name_type():
return None
@ -5843,6 +5851,10 @@ class NatGateway(CloudFormationModel):
self._backend.associate_address(eni=self._eni, allocation_id=self.allocation_id)
self.tags = tags
@property
def physical_resource_id(self):
return self.id
@property
def vpc_id(self):
subnet = self._backend.get_subnet(self.subnet_id)

12
tests/test_cloudformation/test_cloudformation_stack_integration.py
View File

@ -1940,13 +1940,23 @@ def test_nat_gateway():
cf_conn = boto3.client("cloudformation", "us-east-1")
cf_conn.create_stack(StackName="test_stack", TemplateBody=json.dumps(template))
stack_resources = cf_conn.list_stack_resources(StackName="test_stack")
nat_gateway_resource = stack_resources.get("StackResourceSummaries")[0]
for resource in stack_resources["StackResourceSummaries"]:
if resource["ResourceType"] == "AWS::EC2::NatGateway":
nat_gateway_resource = resource
elif resource["ResourceType"] == "AWS::EC2::Route":
route_resource = resource
result = ec2_conn.describe_nat_gateways()
result["NatGateways"].should.have.length_of(1)
result["NatGateways"][0]["VpcId"].should.equal(vpc_id)
result["NatGateways"][0]["SubnetId"].should.equal(subnet_id)
result["NatGateways"][0]["State"].should.equal("available")
result["NatGateways"][0]["NatGatewayId"].should.equal(
nat_gateway_resource.get("PhysicalResourceId")
)
route_resource.get("PhysicalResourceId").should.contain("rtb-")
@mock_cloudformation()