Yasuke/moto
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #507 from pcraciunoiu/feature/dynamodb-update-del-missing

Browse Source 
Delete missing attribute results in KeyError.
This commit is contained in:
Steve Pulec 2016-01-11 13:26:27 -05:00
commit 066b6bf732
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
moto/dynamodb2/models.py
View File

@ -125,7 +125,8 @@ class Item(object):
for attribute_name, update_action in attribute_updates.items(): for attribute_name, update_action in attribute_updates.items():
action = update_action['Action'] action = update_action['Action']
if action == 'DELETE' and not 'Value' in update_action: if action == 'DELETE' and not 'Value' in update_action:
del self.attrs[attribute_name] if attribute_name in self.attrs:
del self.attrs[attribute_name]
continue continue
new_value = list(update_action['Value'].values())[0] new_value = list(update_action['Value'].values())[0]
if action == 'PUT': if action == 'PUT':
@ -137,7 +138,8 @@ class Item(object):
elif update_action['Value'].keys() == ['N']: elif update_action['Value'].keys() == ['N']:
self.attrs[attribute_name] = DynamoType({"N": new_value}) self.attrs[attribute_name] = DynamoType({"N": new_value})
elif update_action['Value'].keys() == ['NULL']: elif update_action['Value'].keys() == ['NULL']:
del self.attrs[attribute_name] if attribute_name in self.attrs:
del self.attrs[attribute_name]
else: else:
self.attrs[attribute_name] = DynamoType({"S": new_value}) self.attrs[attribute_name] = DynamoType({"S": new_value})