Yasuke/moto
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix JSON dump error in ecs.update_service with task_definition (#775)

Browse Source
This commit is contained in:
Pior Bastida 2016-11-23 20:01:48 -05:00 committed by Steve Pulec
parent 4ea915fc3a
commit 09ca1c4388
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
moto/ecs/models.py
View File

@ -375,8 +375,8 @@ class EC2ContainerServiceBackend(BaseBackend):
cluster_service_pair = '{0}:{1}'.format(cluster_name, service_name) cluster_service_pair = '{0}:{1}'.format(cluster_name, service_name)
if cluster_service_pair in self.services: if cluster_service_pair in self.services:
if task_definition_str is not None: if task_definition_str is not None:
task_definition = self.fetch_task_definition(task_definition_str) self.fetch_task_definition(task_definition_str)
self.services[cluster_service_pair].task_definition = task_definition self.services[cluster_service_pair].task_definition = task_definition_str
if desired_count is not None: if desired_count is not None:
self.services[cluster_service_pair].desired_count = desired_count self.services[cluster_service_pair].desired_count = desired_count
return self.services[cluster_service_pair] return self.services[cluster_service_pair]

1
tests/test_ecs/test_ecs_boto3.py
View File

@ -398,6 +398,7 @@ def test_update_service():
response = client.update_service( response = client.update_service(
cluster='test_ecs_cluster', cluster='test_ecs_cluster',
service='test_ecs_service', service='test_ecs_service',
taskDefinition='test_ecs_task',
desiredCount=0 desiredCount=0
) )
response['service']['desiredCount'].should.equal(0) response['service']['desiredCount'].should.equal(0)