Techdebt: Replace sure with regular assertions in CloudWatch (#6493)

tests/test_cloudwatch/test_cloudwatch_alarms.py

@@ -1,5 +1,4 @@
 import boto3
-import sure  # noqa # pylint: disable=unused-import
 
 from moto import mock_cloudwatch
 from moto.core import DEFAULT_ACCOUNT_ID as ACCOUNT_ID
@@ -29,29 +28,25 @@ def test_create_alarm():
     )
 
     alarms = cloudwatch.describe_alarms()["MetricAlarms"]
-    alarms.should.have.length_of(1)
+    assert len(alarms) == 1
     alarm = alarms[0]
-    alarm.should.have.key("AlarmName").equal("tester")
-    alarm.should.have.key("Namespace").equal("tester_namespace")
-    alarm.should.have.key("MetricName").equal("tester_metric")
-    alarm.should.have.key("ComparisonOperator").equal("GreaterThanOrEqualToThreshold")
-    alarm.should.have.key("Threshold").equal(2.0)
-    alarm.should.have.key("Period").equal(60)
-    alarm.should.have.key("EvaluationPeriods").equal(5)
-    alarm.should.have.key("Statistic").should.equal("Average")
-    alarm.should.have.key("AlarmDescription").equal("A test")
-    alarm.should.have.key("Dimensions").equal(
-        [{"Name": "InstanceId", "Value": "i-0123457"}]
-    )
-    alarm.should.have.key("AlarmActions").equal(["arn:alarm"])
-    alarm.should.have.key("OKActions").equal(["arn:ok"])
-    alarm.should.have.key("InsufficientDataActions").equal(["arn:insufficient"])
-    alarm.should.have.key("Unit").equal("Seconds")
-    alarm.should.have.key("AlarmArn").equal(
-        f"arn:aws:cloudwatch:{region}:{ACCOUNT_ID}:alarm:{name}"
-    )
+    assert alarm["AlarmName"] == "tester"
+    assert alarm["Namespace"] == "tester_namespace"
+    assert alarm["MetricName"] == "tester_metric"
+    assert alarm["ComparisonOperator"] == "GreaterThanOrEqualToThreshold"
+    assert alarm["Threshold"] == 2.0
+    assert alarm["Period"] == 60
+    assert alarm["EvaluationPeriods"] == 5
+    assert alarm["Statistic"] == "Average"
+    assert alarm["AlarmDescription"] == "A test"
+    assert alarm["Dimensions"] == [{"Name": "InstanceId", "Value": "i-0123457"}]
+    assert alarm["AlarmActions"] == ["arn:alarm"]
+    assert alarm["OKActions"] == ["arn:ok"]
+    assert alarm["InsufficientDataActions"] == ["arn:insufficient"]
+    assert alarm["Unit"] == "Seconds"
+    assert alarm["AlarmArn"] == f"arn:aws:cloudwatch:{region}:{ACCOUNT_ID}:alarm:{name}"
     # default value should be True
-    alarm.should.have.key("ActionsEnabled").equal(True)
+    assert alarm["ActionsEnabled"] is True
 
 
 @mock_cloudwatch
@@ -59,7 +54,7 @@ def test_delete_alarm():
     cloudwatch = boto3.client("cloudwatch", region_name="eu-central-1")
 
     alarms = cloudwatch.describe_alarms()["MetricAlarms"]
-    alarms.should.have.length_of(0)
+    assert len(alarms) == 0
 
     name = "tester"
     cloudwatch.put_metric_alarm(
@@ -80,12 +75,12 @@ def test_delete_alarm():
     )
 
     alarms = cloudwatch.describe_alarms()["MetricAlarms"]
-    alarms.should.have.length_of(1)
+    assert len(alarms) == 1
 
     cloudwatch.delete_alarms(AlarmNames=[name])
 
     alarms = cloudwatch.describe_alarms()["MetricAlarms"]
-    alarms.should.have.length_of(0)
+    assert len(alarms) == 0
 
 
 @mock_cloudwatch
@@ -112,10 +107,10 @@ def test_describe_alarms_for_metric():
         ActionsEnabled=True,
     )
     alarms = conn.describe_alarms_for_metric(MetricName="cpu", Namespace="blah")
-    alarms.get("MetricAlarms").should.have.length_of(1)
+    assert len(alarms.get("MetricAlarms")) == 1
     alarm = alarms.get("MetricAlarms")[0]
     assert "testalarm1" in alarm.get("AlarmArn")
-    alarm.should.have.key("ActionsEnabled").equal(True)
+    assert alarm["ActionsEnabled"] is True
 
 
 @mock_cloudwatch
@@ -177,7 +172,7 @@ def test_describe_alarms():
     )
     alarms = conn.describe_alarms()
     metric_alarms = alarms.get("MetricAlarms")
-    metric_alarms.should.have.length_of(2)
+    assert len(metric_alarms) == 2
     single_metric_alarm = [
         alarm for alarm in metric_alarms if alarm["AlarmName"] == "testalarm1"
     ][0]
@@ -185,23 +180,23 @@ def test_describe_alarms():
         alarm for alarm in metric_alarms if alarm["AlarmName"] == "testalarm2"
     ][0]
 
-    single_metric_alarm["MetricName"].should.equal("cpu")
-    single_metric_alarm.shouldnt.have.property("Metrics")
-    single_metric_alarm["Namespace"].should.equal("blah")
-    single_metric_alarm["Period"].should.equal(10)
-    single_metric_alarm["EvaluationPeriods"].should.equal(5)
-    single_metric_alarm["Statistic"].should.equal("Average")
-    single_metric_alarm["ComparisonOperator"].should.equal("GreaterThanThreshold")
-    single_metric_alarm["Threshold"].should.equal(2)
-    single_metric_alarm["ActionsEnabled"].should.equal(False)
+    assert single_metric_alarm["MetricName"] == "cpu"
+    assert "Metrics" not in single_metric_alarm
+    assert single_metric_alarm["Namespace"] == "blah"
+    assert single_metric_alarm["Period"] == 10
+    assert single_metric_alarm["EvaluationPeriods"] == 5
+    assert single_metric_alarm["Statistic"] == "Average"
+    assert single_metric_alarm["ComparisonOperator"] == "GreaterThanThreshold"
+    assert single_metric_alarm["Threshold"] == 2
+    assert single_metric_alarm["ActionsEnabled"] is False
 
-    multiple_metric_alarm.shouldnt.have.property("MetricName")
-    multiple_metric_alarm["EvaluationPeriods"].should.equal(1)
-    multiple_metric_alarm["DatapointsToAlarm"].should.equal(1)
-    multiple_metric_alarm["Metrics"].should.equal(metric_data_queries)
-    multiple_metric_alarm["ComparisonOperator"].should.equal("GreaterThanThreshold")
-    multiple_metric_alarm["Threshold"].should.equal(1.0)
-    multiple_metric_alarm["ActionsEnabled"].should.equal(True)
+    assert "MetricName" not in multiple_metric_alarm
+    assert multiple_metric_alarm["EvaluationPeriods"] == 1
+    assert multiple_metric_alarm["DatapointsToAlarm"] == 1
+    assert multiple_metric_alarm["Metrics"] == metric_data_queries
+    assert multiple_metric_alarm["ComparisonOperator"] == "GreaterThanThreshold"
+    assert multiple_metric_alarm["Threshold"] == 1.0
+    assert multiple_metric_alarm["ActionsEnabled"] is True
 
 
 @mock_cloudwatch
@@ -239,17 +234,17 @@ def test_alarm_state():
     )
 
     resp = client.describe_alarms(StateValue="ALARM")
-    len(resp["MetricAlarms"]).should.equal(1)
-    resp["MetricAlarms"][0]["AlarmName"].should.equal("testalarm1")
-    resp["MetricAlarms"][0]["StateValue"].should.equal("ALARM")
-    resp["MetricAlarms"][0]["ActionsEnabled"].should.equal(True)
+    assert len(resp["MetricAlarms"]) == 1
+    assert resp["MetricAlarms"][0]["AlarmName"] == "testalarm1"
+    assert resp["MetricAlarms"][0]["StateValue"] == "ALARM"
+    assert resp["MetricAlarms"][0]["ActionsEnabled"] is True
 
     resp = client.describe_alarms(StateValue="OK")
-    len(resp["MetricAlarms"]).should.equal(1)
-    resp["MetricAlarms"][0]["AlarmName"].should.equal("testalarm2")
-    resp["MetricAlarms"][0]["StateValue"].should.equal("OK")
-    resp["MetricAlarms"][0]["ActionsEnabled"].should.equal(True)
+    assert len(resp["MetricAlarms"]) == 1
+    assert resp["MetricAlarms"][0]["AlarmName"] == "testalarm2"
+    assert resp["MetricAlarms"][0]["StateValue"] == "OK"
+    assert resp["MetricAlarms"][0]["ActionsEnabled"] is True
 
     # Just for sanity
     resp = client.describe_alarms()
-    len(resp["MetricAlarms"]).should.equal(2)
+    assert len(resp["MetricAlarms"]) == 2

tests/test_cloudwatch/test_cloudwatch_dashboards.py

@@ -1,6 +1,6 @@
 import boto3
+import pytest
 from botocore.exceptions import ClientError
-import sure  # noqa # pylint: disable=unused-import
 
 from moto import mock_cloudwatch
 
@@ -13,7 +13,7 @@ def test_put_list_dashboard():
     client.put_dashboard(DashboardName="test1", DashboardBody=widget)
     resp = client.list_dashboards()
 
-    len(resp["DashboardEntries"]).should.equal(1)
+    assert len(resp["DashboardEntries"]) == 1
 
 
 @mock_cloudwatch
@@ -24,7 +24,7 @@ def test_put_list_prefix_nomatch_dashboard():
     client.put_dashboard(DashboardName="test1", DashboardBody=widget)
     resp = client.list_dashboards(DashboardNamePrefix="nomatch")
 
-    len(resp["DashboardEntries"]).should.equal(0)
+    assert len(resp["DashboardEntries"]) == 0
 
 
 @mock_cloudwatch
@@ -38,7 +38,7 @@ def test_delete_dashboard():
     client.delete_dashboards(DashboardNames=["test2", "test1"])
 
     resp = client.list_dashboards(DashboardNamePrefix="test3")
-    len(resp["DashboardEntries"]).should.equal(1)
+    assert len(resp["DashboardEntries"]) == 1
 
 
 @mock_cloudwatch
@@ -49,16 +49,13 @@ def test_delete_dashboard_fail():
     client.put_dashboard(DashboardName="test1", DashboardBody=widget)
     client.put_dashboard(DashboardName="test2", DashboardBody=widget)
     client.put_dashboard(DashboardName="test3", DashboardBody=widget)
-    # Doesnt delete anything if all dashboards to be deleted do not exist
-    try:
+    # Doesn't delete anything if some dashboards to be deleted do not exist
+    with pytest.raises(ClientError) as exc:
         client.delete_dashboards(DashboardNames=["test2", "test1", "test_no_match"])
-    except ClientError as err:
-        err.response["Error"]["Code"].should.equal("ResourceNotFound")
-    else:
-        raise RuntimeError("Should have raised error")
+    assert exc.value.response["Error"]["Code"] == "ResourceNotFound"
 
     resp = client.list_dashboards()
-    len(resp["DashboardEntries"]).should.equal(3)
+    assert len(resp["DashboardEntries"]) == 3
 
 
 @mock_cloudwatch
@@ -68,18 +65,15 @@ def test_get_dashboard():
     client.put_dashboard(DashboardName="test1", DashboardBody=widget)
 
     resp = client.get_dashboard(DashboardName="test1")
-    resp.should.contain("DashboardArn")
-    resp.should.contain("DashboardBody")
-    resp["DashboardName"].should.equal("test1")
+    assert "DashboardArn" in resp
+    assert "DashboardBody" in resp
+    assert resp["DashboardName"] == "test1"
 
 
 @mock_cloudwatch
 def test_get_dashboard_fail():
     client = boto3.client("cloudwatch", region_name="eu-central-1")
 
-    try:
+    with pytest.raises(ClientError) as exc:
         client.get_dashboard(DashboardName="test1")
-    except ClientError as err:
-        err.response["Error"]["Code"].should.equal("ResourceNotFound")
-    else:
-        raise RuntimeError("Should have raised error")
+    assert exc.value.response["Error"]["Code"] == "ResourceNotFound"

tests/test_cloudwatch/test_cloudwatch_tags.py

@@ -3,7 +3,6 @@ from operator import itemgetter
 import boto3
 from botocore.exceptions import ClientError
 import pytest
-import sure  # noqa # pylint: disable=unused-import
 
 from moto import mock_cloudwatch
 from moto.cloudwatch.utils import make_arn_for_alarm
@@ -40,7 +39,7 @@ def test_list_tags_for_resource():
     response = client.list_tags_for_resource(ResourceARN=arn)
 
     # then
-    response["Tags"].should.equal([{"Key": "key-1", "Value": "value-1"}])
+    assert response["Tags"] == [{"Key": "key-1", "Value": "value-1"}]
 
 
 @mock_cloudwatch
@@ -57,7 +56,7 @@ def test_list_tags_for_resource_with_unknown_resource():
     )
 
     # then
-    response["Tags"].should.equal([])
+    assert response["Tags"] == []
 
 
 @mock_cloudwatch
@@ -91,15 +90,10 @@ def test_tag_resource():
 
     # then
     response = client.list_tags_for_resource(ResourceARN=arn)
-    sorted(response["Tags"], key=itemgetter("Key")).should.equal(
-        sorted(
-            [
-                {"Key": "key-1", "Value": "value-1"},
-                {"Key": "key-2", "Value": "value-2"},
-            ],
-            key=itemgetter("Key"),
-        )
-    )
+    assert sorted(response["Tags"], key=itemgetter("Key")) == [
+        {"Key": "key-1", "Value": "value-1"},
+        {"Key": "key-2", "Value": "value-2"},
+    ]
 
 
 @mock_cloudwatch
@@ -117,7 +111,7 @@ def test_tag_resource_on_resource_without_tags():
     alarm_arn = alarms["MetricAlarms"][0]["AlarmArn"]
 
     # List 0 tags - none have been added
-    cw.list_tags_for_resource(ResourceARN=alarm_arn)["Tags"].should.equal([])
+    assert cw.list_tags_for_resource(ResourceARN=alarm_arn)["Tags"] == []
 
     # Tag the Alarm for the first time
     cw.tag_resource(ResourceARN=alarm_arn, Tags=[{"Key": "tk", "Value": "tv"}])
@@ -141,10 +135,10 @@ def test_tag_resource_error_not_exists():
 
     # then
     ex = e.value
-    ex.operation_name.should.equal("TagResource")
-    ex.response["ResponseMetadata"]["HTTPStatusCode"].should.equal(404)
-    ex.response["Error"]["Code"].should.contain("ResourceNotFoundException")
-    ex.response["Error"]["Message"].should.equal("Unknown")
+    assert ex.operation_name == "TagResource"
+    assert ex.response["ResponseMetadata"]["HTTPStatusCode"] == 404
+    assert ex.response["Error"]["Code"] == "ResourceNotFoundException"
+    assert ex.response["Error"]["Message"] == "Unknown"
 
 
 @mock_cloudwatch
@@ -181,7 +175,7 @@ def test_untag_resource():
 
     # then
     response = client.list_tags_for_resource(ResourceARN=arn)
-    response["Tags"].should.equal([{"Key": "key-1", "Value": "value-1"}])
+    assert response["Tags"] == [{"Key": "key-1", "Value": "value-1"}]
 
 
 @mock_cloudwatch
@@ -201,7 +195,7 @@ def test_untag_resource_error_not_exists():
 
     # then
     ex = e.value
-    ex.operation_name.should.equal("UntagResource")
-    ex.response["ResponseMetadata"]["HTTPStatusCode"].should.equal(404)
-    ex.response["Error"]["Code"].should.contain("ResourceNotFoundException")
-    ex.response["Error"]["Message"].should.equal("Unknown")
+    assert ex.operation_name == "UntagResource"
+    assert ex.response["ResponseMetadata"]["HTTPStatusCode"] == 404
+    assert ex.response["Error"]["Code"] == "ResourceNotFoundException"
+    assert ex.response["Error"]["Message"] == "Unknown"