SNS - enable more Terraform tests (#5051)

2022-04-23 09:45:05 +00:00 · 2022-04-23 09:45:05 +00:00 · 0e5c2e4f6b
commit 0e5c2e4f6b
parent 752eee1941
3 changed files with 10 additions and 2 deletions
--- a/moto/sns/responses.py
+++ b/moto/sns/responses.py
@ -1119,10 +1119,12 @@ GET_SMS_ATTRIBUTES_TEMPLATE = """<GetSMSAttributesResponse xmlns="http://sns.ama
  <GetSMSAttributesResult>
    <attributes>
      {% for name, value in attributes.items() %}
+      {% if value %}
      <entry>
        <key>{{ name }}</key>
        <value>{{ value }}</value>
      </entry>
+      {% endif %}
      {% endfor %}
    </attributes>
  </GetSMSAttributesResult>
--- a/tests/terraformtests/terraform-tests.failures.txt
+++ b/tests/terraformtests/terraform-tests.failures.txt
@ -55,8 +55,6 @@ TestAccPinpointApp
 TestAccPinpointEventStream
 TestAccProvider
 TestAccQuickSightGroup
-TestAccSNSSMSPreferences
-TestAccSNSTopicPolicy
 TestAccSQSQueuePolicy
 TestAccSSMDocument
 TestAccSsmDocumentDataSource
--- a/tests/terraformtests/terraform-tests.success.txt
+++ b/tests/terraformtests/terraform-tests.success.txt
@ -106,7 +106,15 @@ s3:
  - TestAccS3ObjectCopy
 sagemaker:
  - TestAccSageMakerPrebuiltECRImageDataSource
+sns:
+  - TestAccSNSTopicPolicy
+  - TestAccSNSTopicDataSource
+  - TestAccSNSSMSPreferences
 sts:
  - TestAccSTSCallerIdentityDataSource
+sqs:
+  - TestAccSQSQueueDataSource
+  - TestAccSQSQueuePolicy
+  - TestAccSQSQueue_FIFOQueue_
 timestreamwrite:
  - TestAccTimestreamWriteDatabase