Yasuke/moto
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix: handling of boolean value privateDnsEnabled in ec2:VpcEndpoint (#3566)

Browse Source 
* Properly coerce `privateDnsEnabled` to boolean value when parsing requests.
* Per AWS spec, default `privateDnsEnabled` request value to `True`.
* Properly serialize `privateDnsEnabled` as boolean value in responses.
* Add test coverage.

Ref: #3540
This commit is contained in:
Brian Pandola 2021-01-08 00:05:44 -08:00 committed by GitHub
parent bce682a867
commit 1a98c4f14a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
moto/ec2/responses/vpcs.py
View File

@ -178,7 +178,7 @@ class VPCs(BaseResponse):
policy_document = self._get_param("PolicyDocument") policy_document = self._get_param("PolicyDocument")
client_token = self._get_param("ClientToken") client_token = self._get_param("ClientToken")
tag_specifications = self._get_param("TagSpecifications") tag_specifications = self._get_param("TagSpecifications")
private_dns_enabled = self._get_param("PrivateDNSEnabled") private_dns_enabled = self._get_bool_param("PrivateDNSEnabled", if_none=True)
security_group = self._get_param("SecurityGroup") security_group = self._get_param("SecurityGroup")
vpc_end_point = self.ec2_backend.create_vpc_endpoint( vpc_end_point = self.ec2_backend.create_vpc_endpoint(
@ -456,6 +456,7 @@ CREATE_VPC_END_POINT = """ <CreateVpcEndpointResponse xmlns="http://monitoring.a
<item>{{ subnetId }}</item> <item>{{ subnetId }}</item>
{% endfor %} {% endfor %}
</subnetIdSet> </subnetIdSet>
<privateDnsEnabled>{{ 'true' if vpc_end_point.private_dns_enabled else 'false' }}</privateDnsEnabled>
<dnsEntrySet> <dnsEntrySet>
{% if vpc_end_point.dns_entries %} {% if vpc_end_point.dns_entries %}
{% for entry in vpc_end_point.dns_entries %} {% for entry in vpc_end_point.dns_entries %}
@ -511,7 +512,7 @@ DESCRIBE_VPC_ENDPOINT_RESPONSE = """<DescribeVpcEndpointsResponse xmlns="http://
<policyDocument>{{ vpc_end_point.policy_document }}</policyDocument> <policyDocument>{{ vpc_end_point.policy_document }}</policyDocument>
{% endif %} {% endif %}
<state>available</state> <state>available</state>
<privateDnsEnabled>{{ vpc_end_point.private_dns_enabled }}</privateDnsEnabled> <privateDnsEnabled>{{ 'true' if vpc_end_point.private_dns_enabled else 'false' }}</privateDnsEnabled>
<serviceName>{{ vpc_end_point.service_name }}</serviceName> <serviceName>{{ vpc_end_point.service_name }}</serviceName>
<vpcId>{{ vpc_end_point.vpc_id }}</vpcId> <vpcId>{{ vpc_end_point.vpc_id }}</vpcId>
<vpcEndpointId>{{ vpc_end_point.id }}</vpcEndpointId> <vpcEndpointId>{{ vpc_end_point.id }}</vpcEndpointId>

5
tests/test_ec2/test_vpcs.py
View File

@ -885,6 +885,11 @@ def test_describe_vpc_end_points():
) )
vpc_endpoints = ec2.describe_vpc_endpoints() vpc_endpoints = ec2.describe_vpc_endpoints()
assert (
vpc_endpoints.get("VpcEndpoints")[0].get("PrivateDnsEnabled")
is vpc_end_point.get("VpcEndpoint").get("PrivateDnsEnabled")
is True
)
assert vpc_endpoints.get("VpcEndpoints")[0].get( assert vpc_endpoints.get("VpcEndpoints")[0].get(
"VpcEndpointId" "VpcEndpointId"
) == vpc_end_point.get("VpcEndpoint").get("VpcEndpointId") ) == vpc_end_point.get("VpcEndpoint").get("VpcEndpointId")