Yasuke/moto
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #645 from paulci/describe_security_groups_boto3

Browse Source 
Support Filters in describe_security_groups() for boto3
This commit is contained in:
Steve Pulec 2016-07-09 20:56:43 -04:00 committed by GitHub
commit 219ed703fb
2 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
moto/ec2/models.py
View File

@ -1226,6 +1226,8 @@ class SecurityGroup(TaggedEC2Resource):
return True return True
elif is_tag_filter(key): elif is_tag_filter(key):
tag_value = self.get_filter_value(key) tag_value = self.get_filter_value(key)
if isinstance(filter_value, list):
return any(v in tag_value for v in filter_value)
return tag_value in filter_value return tag_value in filter_value
else: else:
attr_name = to_attr(key) attr_name = to_attr(key)

16
tests/test_ec2/test_security_groups.py
View File

@ -326,3 +326,19 @@ def test_authorize_all_protocols_with_no_port_specification():
sg = conn.get_all_security_groups('test')[0] sg = conn.get_all_security_groups('test')[0]
sg.rules[0].from_port.should.equal(None) sg.rules[0].from_port.should.equal(None)
sg.rules[0].to_port.should.equal(None) sg.rules[0].to_port.should.equal(None)
'''
Boto3
'''
@mock_ec2
def test_security_group_tagging_boto3():
conn = boto3.client('ec2', region_name='us-east-1')
sg = conn.create_security_group(GroupName="test-sg", Description="Test SG")
conn.create_tags(Resources=[sg['GroupId']], Tags=[{'Key': 'Test', 'Value': 'Tag'}])
describe = conn.describe_security_groups(Filters=[{'Name': 'tag-value', 'Values': ['Tag']}])
tag = describe["SecurityGroups"][0]['Tags'][0]
tag['Value'].should.equal("Tag")
tag['Key'].should.equal("Test")