From 26980f41a66b3afbe5ba67e8cb66354b6f4bdef0 Mon Sep 17 00:00:00 2001 From: Jean-Baptiste Barth Date: Thu, 19 Nov 2015 11:44:51 +0100 Subject: [PATCH] Replace globals() call with a static mapping (suggested in @spulec review) --- moto/swf/models/__init__.py | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/moto/swf/models/__init__.py b/moto/swf/models/__init__.py index b9d7be0fd..29fda4a3a 100644 --- a/moto/swf/models/__init__.py +++ b/moto/swf/models/__init__.py @@ -25,6 +25,12 @@ from .workflow_type import WorkflowType from .workflow_execution import WorkflowExecution +KNOWN_SWF_TYPES = { + "activity": ActivityType, + "workflow": WorkflowType, +} + + class SWFBackend(BaseBackend): def __init__(self, region_name): self.region_name = region_name @@ -119,7 +125,7 @@ class SWFBackend(BaseBackend): _type = domain.get_type(kind, name, version, ignore_empty=True) if _type: raise SWFTypeAlreadyExistsFault(_type) - _class = globals()["{0}Type".format(kind.capitalize())] + _class = KNOWN_SWF_TYPES[kind] _type = _class(name, version, **kwargs) domain.add_type(_type)