Yasuke/moto
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Techdebt: Ensure RT API has unique tag keys (#6587)

Browse Source
This commit is contained in:
Bert Blommers 2023-08-01 22:46:10 +00:00 committed by GitHub
parent 80f6cd78d1
commit 28837234c5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
tests/test_resourcegroupstaggingapi/test_resourcegroupstagging_glue.py
View File

@ -9,11 +9,13 @@ from uuid import uuid4
@mock_resourcegroupstaggingapi @mock_resourcegroupstaggingapi
def test_glue_jobs(): def test_glue_jobs():
glue = boto3.client("glue", region_name="us-west-1") glue = boto3.client("glue", region_name="us-west-1")
tag_key = str(uuid4())[0:6]
tag_val = str(uuid4())[0:6]
job_name = glue.create_job( job_name = glue.create_job(
Name=str(uuid4()), Name=str(uuid4()),
Role="test_role", Role="test_role",
Command=dict(Name="test_command"), Command=dict(Name="test_command"),
Tags={"k1": "v1"}, Tags={tag_key: tag_val},
)["Name"] )["Name"]
job_arn = f"arn:aws:glue:us-west-1:{DEFAULT_ACCOUNT_ID}:job/{job_name}" job_arn = f"arn:aws:glue:us-west-1:{DEFAULT_ACCOUNT_ID}:job/{job_name}"
@ -22,21 +24,21 @@ def test_glue_jobs():
"ResourceTagMappingList" "ResourceTagMappingList"
] ]
assert resources == [ assert resources == [
{"ResourceARN": job_arn, "Tags": [{"Key": "k1", "Value": "v1"}]} {"ResourceARN": job_arn, "Tags": [{"Key": tag_key, "Value": tag_val}]}
] ]
resources = rtapi.get_resources(ResourceTypeFilters=["glue:job"])[ resources = rtapi.get_resources(ResourceTypeFilters=["glue:job"])[
"ResourceTagMappingList" "ResourceTagMappingList"
] ]
assert resources == [ assert resources == [
{"ResourceARN": job_arn, "Tags": [{"Key": "k1", "Value": "v1"}]} {"ResourceARN": job_arn, "Tags": [{"Key": tag_key, "Value": tag_val}]}
] ]
resources = rtapi.get_resources(TagFilters=[{"Key": "k1", "Values": ["v1"]}])[ resources = rtapi.get_resources(TagFilters=[{"Key": tag_key, "Values": [tag_val]}])[
"ResourceTagMappingList" "ResourceTagMappingList"
] ]
assert resources == [ assert resources == [
{"ResourceARN": job_arn, "Tags": [{"Key": "k1", "Value": "v1"}]} {"ResourceARN": job_arn, "Tags": [{"Key": tag_key, "Value": tag_val}]}
] ]
resources = rtapi.get_resources(ResourceTypeFilters=["glue:table"])[ resources = rtapi.get_resources(ResourceTypeFilters=["glue:table"])[
@ -44,12 +46,7 @@ def test_glue_jobs():
] ]
assert resources == [] assert resources == []
resources = rtapi.get_resources(ResourceTypeFilters=["ec2"])[ assert rtapi.get_tag_keys()["TagKeys"] == [tag_key]
"ResourceTagMappingList"
]
assert resources == []
assert rtapi.get_tag_keys()["TagKeys"] == ["k1"] assert rtapi.get_tag_values(Key=tag_key)["TagValues"] == [tag_val]
assert rtapi.get_tag_values(Key="k1")["TagValues"] == ["v1"]
assert rtapi.get_tag_values(Key="unknown")["TagValues"] == [] assert rtapi.get_tag_values(Key="unknown")["TagValues"] == []