Yasuke/moto
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Deregister batch job definition by 'name:revision' (#4355)

Browse Source
This commit is contained in:
oakbramble 2021-09-27 19:19:44 +02:00 committed by GitHub
parent de2e627c41
commit 30c8c3de1f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 19 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
moto/batch/models.py
View File

@ -718,7 +718,7 @@ class BatchBackend(BaseBackend):
def get_job_definition_by_name_revision(self, name, revision): def get_job_definition_by_name_revision(self, name, revision):
for job_def in self._job_definitions.values(): for job_def in self._job_definitions.values():
if job_def.name == name and job_def.revision == revision: if job_def.name == name and job_def.revision == int(revision):
return job_def return job_def
return None return None

18
tests/test_batch/test_batch_task_definition.py
View File

@ -97,6 +97,24 @@ def test_delete_task_definition():
len(resp["jobDefinitions"]).should.equal(0) len(resp["jobDefinitions"]).should.equal(0)
@mock_ec2
@mock_ecs
@mock_iam
@mock_batch
def test_delete_task_definition_by_name():
ec2_client, iam_client, ecs_client, logs_client, batch_client = _get_clients()
_setup(ec2_client, iam_client)
resp = register_job_def(batch_client)
batch_client.deregister_job_definition(
jobDefinition=f"{resp['jobDefinitionName']}:{resp['revision']}"
)
resp = batch_client.describe_job_definitions()
len(resp["jobDefinitions"]).should.equal(0)
@mock_ec2 @mock_ec2
@mock_ecs @mock_ecs
@mock_iam @mock_iam