From 37cb5ab4e69f1ef977256aba07f38f546d40e918 Mon Sep 17 00:00:00 2001 From: William Rubel Date: Sun, 17 Feb 2019 14:36:53 -0600 Subject: [PATCH] Add test for roles --- moto/iam/responses.py | 5 +++-- tests/test_iam/test_iam.py | 27 +++++++++++++++++++++++++++ 2 files changed, 30 insertions(+), 2 deletions(-) diff --git a/moto/iam/responses.py b/moto/iam/responses.py index e624c18c3..c981f9b35 100644 --- a/moto/iam/responses.py +++ b/moto/iam/responses.py @@ -176,14 +176,14 @@ class IamResponse(BaseResponse): def update_role_description(self): role_name = self._get_param('RoleName') description = self._get_param('Description') - role = iam_backend.update_role_description(role_name,description) + role = iam_backend.update_role_description(role_name, description) template = self.response_template(UPDATE_ROLE_DESCRIPTION_TEMPLATE) return template.render(role=role) def update_role(self): role_name = self._get_param('RoleName') description = self._get_param('Description') - role = iam_backend.update_role_description(role_name,description) + role = iam_backend.update_role_description(role_name, description) template = self.response_template(UPDATE_ROLE_DESCRIPTION_TEMPLATE) return template.render(role=role) @@ -672,6 +672,7 @@ class IamResponse(BaseResponse): template = self.response_template(UNTAG_ROLE_TEMPLATE) return template.render() + LIST_ENTITIES_FOR_POLICY_TEMPLATE = """ diff --git a/tests/test_iam/test_iam.py b/tests/test_iam/test_iam.py index d5f1bb4f9..80a7fe99e 100644 --- a/tests/test_iam/test_iam.py +++ b/tests/test_iam/test_iam.py @@ -1151,3 +1151,30 @@ def test_untag_role(): # With a role that doesn't exist: with assert_raises(ClientError): conn.untag_role(RoleName='notarole', TagKeys=['somevalue']) + + +@mock_iam() +def test_update_role_description(): + conn = boto3.client('iam', region_name='us-east-1') + + with assert_raises(ClientError): + conn.delete_role(RoleName="my-role") + + conn.create_role(RoleName="my-role", AssumeRolePolicyDocument="some policy", Path="/my-path/") + role = conn.get_role(RoleName="my-role") + response = conn.update_role_description(RoleName="my-role", Description="test") + + assert response['Role']['RoleName'] == 'my-role' + +@mock_iam() +def test_update_role(): + conn = boto3.client('iam', region_name='us-east-1') + + with assert_raises(ClientError): + conn.delete_role(RoleName="my-role") + + conn.create_role(RoleName="my-role", AssumeRolePolicyDocument="some policy", Path="/my-path/") + role = conn.get_role(RoleName="my-role") + response = conn.update_role_description(RoleName="my-role", Description="test") + + assert response['Role']['RoleName'] == 'my-role' \ No newline at end of file