Yasuke/moto
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

DynamoDB - fix bugfix between 0 and x (#4567)

Browse Source
This commit is contained in:
Bert Blommers 2021-11-12 20:09:03 -01:00 committed by GitHub
parent 16685d3407
commit 3898124112
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
moto/dynamodb2/comparisons.py
View File

@ -1162,7 +1162,11 @@ class FuncBetween(Func):
start = self.start.expr(item)
attr = self.attr.expr(item)
end = self.end.expr(item)
if start and attr and end:
# Need to verify whether start has a valid value
# Can't just check 'if start', because start could be 0, which is a valid integer
start_has_value = start is not None and (isinstance(start, int) or start)
end_has_value = end is not None and (isinstance(end, int) or end)
if start_has_value and attr and end_has_value:
return start <= attr <= end
elif start is None and attr is None:
# None is between None and None as well as None is between None and any number

6
tests/test_dynamodb2/test_dynamodb.py
View File

@ -1551,6 +1551,12 @@ def test_filter_expression():
)
filter_expr.expr(row1).should.be(True)
# BETWEEN integer test
filter_expr = moto.dynamodb2.comparisons.get_filter_expression(
"Id BETWEEN :v0 AND :v1", {}, {":v0": {"N": "0"}, ":v1": {"N": "10"}}
)
filter_expr.expr(row1).should.be(True)
# PAREN test
filter_expr = moto.dynamodb2.comparisons.get_filter_expression(
"Id = :v0 AND (Subs = :v0 OR Subs = :v1)",