improved SWF support

CHANGELOG.md

@@ -3,6 +3,10 @@ Moto Changelog
 
 Latest
 ------
+    * Implemented signal_workflow_execution for SWF
+    * Wired SWF backend to the moto server
+    * Fixed incorrect handling of task list parameter on start_workflow_execution
+    
 1.1.25
 -----
 

IMPLEMENTATION_COVERAGE.md

@@ -3972,7 +3972,7 @@
 - [ ] refresh_trusted_advisor_check
 - [ ] resolve_case
 
-## swf - 54% implemented
+## swf - 58% implemented
 - [ ] count_closed_workflow_executions
 - [ ] count_open_workflow_executions
 - [X] count_pending_activity_tasks
@@ -4001,7 +4001,7 @@
 - [X] respond_activity_task_completed
 - [X] respond_activity_task_failed
 - [X] respond_decision_task_completed
-- [ ] signal_workflow_execution
+- [X] signal_workflow_execution
 - [X] start_workflow_execution
 - [X] terminate_workflow_execution
 

moto/backends.py

@@ -34,6 +34,7 @@ from moto.sns import sns_backends
 from moto.sqs import sqs_backends
 from moto.ssm import ssm_backends
 from moto.sts import sts_backends
+from moto.swf import swf_backends
 from moto.xray import xray_backends
 from moto.iot import iot_backends
 from moto.iotdata import iotdata_backends
@@ -76,6 +77,7 @@ BACKENDS = {
     'sqs': sqs_backends,
     'ssm': ssm_backends,
     'sts': sts_backends,
+    'swf': swf_backends,
     'route53': route53_backends,
     'lambda': lambda_backends,
     'xray': xray_backends,

moto/swf/models/__init__.py

@@ -21,7 +21,7 @@ from .history_event import HistoryEvent  # flake8: noqa
 from .timeout import Timeout  # flake8: noqa
 from .workflow_type import WorkflowType  # flake8: noqa
 from .workflow_execution import WorkflowExecution  # flake8: noqa
-
+from time import sleep
 
 KNOWN_SWF_TYPES = {
     "activity": ActivityType,
@@ -198,6 +198,9 @@ class SWFBackend(BaseBackend):
             wfe.start_decision_task(task.task_token, identity=identity)
             return task
         else:
+            # Sleeping here will prevent clients that rely on the timeout from
+            # entering in a busy waiting loop.
+            sleep(1)
             return None
 
     def count_pending_decision_tasks(self, domain_name, task_list):
@@ -293,6 +296,9 @@ class SWFBackend(BaseBackend):
             wfe.start_activity_task(task.task_token, identity=identity)
             return task
         else:
+            # Sleeping here will prevent clients that rely on the timeout from
+            # entering in a busy waiting loop.
+            sleep(1)
             return None
 
     def count_pending_activity_tasks(self, domain_name, task_list):
@@ -379,6 +385,14 @@ class SWFBackend(BaseBackend):
         if details:
             activity_task.details = details
 
+    def signal_workflow_execution(self, domain_name, signal_name, workflow_id, input=None, run_id=None):
+        # process timeouts on all objects
+        self._process_timeouts()
+        domain = self._get_domain(domain_name)
+        wfe = domain.get_workflow_execution(
+            workflow_id, run_id=run_id, raise_if_closed=True)
+        wfe.signal(signal_name, input)
+
 
 swf_backends = {}
 for region in boto.swf.regions():

moto/swf/models/history_event.py

@@ -25,6 +25,7 @@ SUPPORTED_HISTORY_EVENT_TYPES = (
     "ActivityTaskTimedOut",
     "DecisionTaskTimedOut",
     "WorkflowExecutionTimedOut",
+    "WorkflowExecutionSignaled"
 )
 
 

moto/swf/models/workflow_execution.py

@@ -599,6 +599,14 @@ class WorkflowExecution(BaseModel):
         self.close_status = "TERMINATED"
         self.close_cause = "OPERATOR_INITIATED"
 
+    def signal(self, signal_name, input):
+        self._add_event(
+            "WorkflowExecutionSignaled",
+            signal_name=signal_name,
+            input=input,
+        )
+        self.schedule_decision_task()
+
     def first_timeout(self):
         if not self.open or not self.start_timestamp:
             return None

moto/swf/responses.py

@@ -326,9 +326,9 @@ class SWFResponse(BaseResponse):
         _workflow_type = self._params["workflowType"]
         workflow_name = _workflow_type["name"]
         workflow_version = _workflow_type["version"]
-        _default_task_list = self._params.get("defaultTaskList")
+        _task_list = self._params.get("taskList")
-        if _default_task_list:
+        if _task_list:
-            task_list = _default_task_list.get("name")
+            task_list = _task_list.get("name")
         else:
             task_list = None
         child_policy = self._params.get("childPolicy")
@@ -507,3 +507,20 @@ class SWFResponse(BaseResponse):
         )
         # TODO: make it dynamic when we implement activity tasks cancellation
         return json.dumps({"cancelRequested": False})
+
+    def signal_workflow_execution(self):
+        domain_name = self._params["domain"]
+        signal_name = self._params["signalName"]
+        workflow_id = self._params["workflowId"]
+        _input = self._params["input"]
+        run_id = self._params["runId"]
+
+        self._check_string(domain_name)
+        self._check_string(signal_name)
+        self._check_string(workflow_id)
+        self._check_none_or_string(_input)
+        self._check_none_or_string(run_id)
+
+        self.swf_backend.signal_workflow_execution(
+            domain_name, signal_name, workflow_id, _input, run_id)
+        return ""

tests/test_swf/responses/test_workflow_executions.py

@@ -34,6 +34,20 @@ def test_start_workflow_execution():
         "test-domain", "uid-abcd1234", "test-workflow", "v1.0")
     wf.should.contain("runId")
 
+@mock_swf_deprecated
+def test_signal_workflow_execution():
+    conn = setup_swf_environment()
+    hsh = conn.start_workflow_execution(
+        "test-domain", "uid-abcd1234", "test-workflow", "v1.0")
+    run_id = hsh["runId"]
+
+    wfe = conn.signal_workflow_execution(
+        "test-domain", "my_signal", "uid-abcd1234", "my_input", run_id)
+
+    wfe = conn.describe_workflow_execution(
+        "test-domain", run_id, "uid-abcd1234")
+
+    wfe["openCounts"]["openDecisionTasks"].should.equal(2)
 
 @mock_swf_deprecated
 def test_start_already_started_workflow_execution():