Yasuke/moto
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ECS: Fix a bug where a cluster cannot be tagged after creation (#6226)

Browse Source
This commit is contained in:
Bert Blommers 2023-04-18 13:54:08 +00:00 committed by GitHub
parent 0a19243581
commit 3e21ddd606
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
moto/ecs/models.py
View File

@ -2011,7 +2011,7 @@ class EC2ContainerServiceBackend(BaseBackend):
def tag_resource(self, resource_arn: str, tags: List[Dict[str, str]]) -> None: def tag_resource(self, resource_arn: str, tags: List[Dict[str, str]]) -> None:
parsed_arn = self._parse_resource_arn(resource_arn) parsed_arn = self._parse_resource_arn(resource_arn)
resource = self._get_resource(resource_arn, parsed_arn) resource = self._get_resource(resource_arn, parsed_arn)
resource.tags = self._merge_tags(resource.tags, tags) resource.tags = self._merge_tags(resource.tags or [], tags)
def _merge_tags( def _merge_tags(
self, existing_tags: List[Dict[str, str]], new_tags: List[Dict[str, str]] self, existing_tags: List[Dict[str, str]], new_tags: List[Dict[str, str]]

11
tests/test_ecs/test_ecs_boto3.py
View File

@ -115,7 +115,16 @@ def test_list_clusters():
def test_create_cluster_with_tags(): def test_create_cluster_with_tags():
client = boto3.client("ecs", region_name="us-east-1") client = boto3.client("ecs", region_name="us-east-1")
tag_list = [{"key": "tagName", "value": "TagValue"}] tag_list = [{"key": "tagName", "value": "TagValue"}]
cluster = client.create_cluster(clusterName="c_with_tags", tags=tag_list)["cluster"] cluster = client.create_cluster(clusterName="c1")["cluster"]
resp = client.list_tags_for_resource(resourceArn=cluster["clusterArn"])
assert "tags" not in resp
client.tag_resource(resourceArn=cluster["clusterArn"], tags=tag_list)
tags = client.list_tags_for_resource(resourceArn=cluster["clusterArn"])["tags"]
tags.should.equal([{"key": "tagName", "value": "TagValue"}])
cluster = client.create_cluster(clusterName="c2", tags=tag_list)["cluster"]
tags = client.list_tags_for_resource(resourceArn=cluster["clusterArn"])["tags"] tags = client.list_tags_for_resource(resourceArn=cluster["clusterArn"])["tags"]
tags.should.equal([{"key": "tagName", "value": "TagValue"}]) tags.should.equal([{"key": "tagName", "value": "TagValue"}])