Yasuke/moto
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

LakeFormation: raise AlreadyExistsException when registering an existing resource (#7052)

Browse Source
This commit is contained in:
JohannesKoenigTMH 2023-11-20 23:43:13 +01:00 committed by GitHub
parent 7c5f0ef7a3
commit 4127cb7b9f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 13 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
moto/lakeformation/exceptions.py
View File

@ -10,3 +10,8 @@ class EntityNotFound(JsonRESTError):
class InvalidInput(JsonRESTError): class InvalidInput(JsonRESTError):
def __init__(self, message: str) -> None: def __init__(self, message: str) -> None:
super().__init__("InvalidInputException", message) super().__init__("InvalidInputException", message)
class AlreadyExists(JsonRESTError):
def __init__(self, message: str) -> None:
super().__init__("AlreadyExistsException", message)

6
moto/lakeformation/models.py
View File

@ -4,7 +4,7 @@ from typing import Any, Dict, List, Tuple, Optional
from moto.core import BaseBackend, BackendDict, BaseModel from moto.core import BaseBackend, BackendDict, BaseModel
from moto.utilities.tagging_service import TaggingService from moto.utilities.tagging_service import TaggingService
from .exceptions import EntityNotFound, InvalidInput from .exceptions import EntityNotFound, InvalidInput, AlreadyExists
class RessourceType(Enum): class RessourceType(Enum):
@ -187,6 +187,10 @@ class LakeFormationBackend(BaseBackend):
del self.resources[resource_arn] del self.resources[resource_arn]
def register_resource(self, resource_arn: str, role_arn: str) -> None: def register_resource(self, resource_arn: str, role_arn: str) -> None:
if resource_arn in self.resources:
raise AlreadyExists(
"An error occurred (AlreadyExistsException) when calling the RegisterResource operation: Resource is already registered"
)
self.resources[resource_arn] = Resource(resource_arn, role_arn) self.resources[resource_arn] = Resource(resource_arn, role_arn)
def list_resources(self) -> List[Resource]: def list_resources(self) -> List[Resource]:

6
tests/test_lakeformation/test_lakeformation.py
View File

@ -13,12 +13,12 @@ from moto import mock_lakeformation
@mock_lakeformation @mock_lakeformation
def test_register_resource(): def test_register_resource():
client = boto3.client("lakeformation", region_name="us-east-2") client = boto3.client("lakeformation", region_name="us-east-2")
resp = client.register_resource( resp = client.register_resource(ResourceArn="some arn", RoleArn="another arn")
ResourceArn="some arn",
)
del resp["ResponseMetadata"] del resp["ResponseMetadata"]
assert resp == {} assert resp == {}
with pytest.raises(client.exceptions.AlreadyExistsException):
client.register_resource(ResourceArn="some arn", RoleArn="another arn")
@mock_lakeformation @mock_lakeformation