Yasuke/moto
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #3147 from bblommers/enhancement/3139

Browse Source 
ECS - UpdateService - Allow service ARN to be passed in
This commit is contained in:
Steve Pulec 2020-07-26 15:31:12 -05:00 committed by GitHub
commit 41427a78b6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
moto/ecs/models.py
View File

@ -1028,9 +1028,10 @@ class EC2ContainerServiceBackend(BaseBackend):
return result return result
def update_service( def update_service(
self, cluster_str, service_name, task_definition_str, desired_count self, cluster_str, service_str, task_definition_str, desired_count
): ):
cluster_name = cluster_str.split("/")[-1] cluster_name = cluster_str.split("/")[-1]
service_name = service_str.split("/")[-1]
cluster_service_pair = "{0}:{1}".format(cluster_name, service_name) cluster_service_pair = "{0}:{1}".format(cluster_name, service_name)
if cluster_service_pair in self.services: if cluster_service_pair in self.services:
if task_definition_str is not None: if task_definition_str is not None:

9
tests/test_ecs/test_ecs_boto3.py
View File

@ -660,6 +660,15 @@ def test_update_service():
response["service"]["desiredCount"].should.equal(0) response["service"]["desiredCount"].should.equal(0)
response["service"]["schedulingStrategy"].should.equal("REPLICA") response["service"]["schedulingStrategy"].should.equal("REPLICA")
# Verify we can pass the ARNs of the cluster and service
response = client.update_service(
cluster=response["service"]["clusterArn"],
service=response["service"]["serviceArn"],
taskDefinition="test_ecs_task",
desiredCount=1,
)
response["service"]["desiredCount"].should.equal(1)
@mock_ecs @mock_ecs
def test_update_missing_service(): def test_update_missing_service():