Yasuke/moto
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #1418 from stillwaiting/sns-do-not-duplicate-subscriptions

Browse Source 
SNS: do not duplicate subscriptions
This commit is contained in:
Steve Pulec 2018-03-06 22:40:22 -05:00 committed by GitHub
commit 47ec9bcdc8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 27 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
moto/sns/models.py
View File

@ -247,11 +247,21 @@ class SNSBackend(BaseBackend):
setattr(topic, attribute_name, attribute_value) setattr(topic, attribute_name, attribute_value)
def subscribe(self, topic_arn, endpoint, protocol): def subscribe(self, topic_arn, endpoint, protocol):
# AWS doesn't create duplicates
old_subscription = self._find_subscription(topic_arn, endpoint, protocol)
if old_subscription:
return old_subscription
topic = self.get_topic(topic_arn) topic = self.get_topic(topic_arn)
subscription = Subscription(topic, endpoint, protocol) subscription = Subscription(topic, endpoint, protocol)
self.subscriptions[subscription.arn] = subscription self.subscriptions[subscription.arn] = subscription
return subscription return subscription
def _find_subscription(self, topic_arn, endpoint, protocol):
for subscription in self.subscriptions.values():
if subscription.topic.arn == topic_arn and subscription.endpoint == endpoint and subscription.protocol == protocol:
return subscription
return None
def unsubscribe(self, subscription_arn): def unsubscribe(self, subscription_arn):
self.subscriptions.pop(subscription_arn) self.subscriptions.pop(subscription_arn)

17
tests/test_sns/test_subscriptions_boto3.py
View File

@ -25,6 +25,23 @@ def test_subscribe_sms():
) )
resp.should.contain('SubscriptionArn') resp.should.contain('SubscriptionArn')
@mock_sns
def test_double_subscription():
client = boto3.client('sns', region_name='us-east-1')
client.create_topic(Name="some-topic")
resp = client.create_topic(Name="some-topic")
arn = resp['TopicArn']
do_subscribe_sqs = lambda sqs_arn: client.subscribe(
TopicArn=arn,
Protocol='sqs',
Endpoint=sqs_arn
)
resp1 = do_subscribe_sqs('arn:aws:sqs:elasticmq:000000000000:foo')
resp2 = do_subscribe_sqs('arn:aws:sqs:elasticmq:000000000000:foo')
resp1['SubscriptionArn'].should.equal(resp2['SubscriptionArn'])
@mock_sns @mock_sns
def test_subscribe_bad_sms(): def test_subscribe_bad_sms():