Yasuke/moto
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Issue 1753: Add support for DescribeSecret

Browse Source 
- Merge changes from upstream master.
- Update get_secret_value to use helper method for validating secret
identifier.
- Update implementation coverage checklist.
This commit is contained in:
Neil Roberts 2018-08-14 12:04:39 -07:00
parent 1f499971d1
commit 48a71ae329
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
IMPLEMENTATION_COVERAGE.md
View File

@ -3645,11 +3645,11 @@
- [ ] put_attributes
- [ ] select
## secretsmanager - 20% implemented
## secretsmanager - 27% implemented
- [ ] cancel_rotate_secret
- [X] create_secret
- [ ] delete_secret
- [ ] describe_secret
- [X] describe_secret
- [X] get_random_password
- [X] get_secret_value
- [ ] list_secret_version_ids

2
moto/secretsmanager/models.py
View File

@ -47,7 +47,7 @@ class SecretsManagerBackend(BaseBackend):
def get_secret_value(self, secret_id, version_id, version_stage):
if secret_id not in (self.secret_id, self.name):
if not self._is_valid_identifier(secret_id):
raise ResourceNotFoundException()
response = json.dumps({