Yasuke/moto
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

test_stepfunctions: Fix failures under non-UTC timezone (#3528)

Browse Source 
These tests were passing with TZ=UTC, but under a non-UTC timezone
they were failing:

E       AssertionError: given
E       X = [{'timestamp': datetime.datetime(2020, 1, 1, 0, 0, tzinfo=tzutc()), …}, …]
E           and
E       Y = [{'timestamp': datetime.datetime(2020, 1, 1, 0, 0, tzinfo=tzlocal()), …}, …]
E       X[0]['timestamp'] != Y[0]['timestamp']

With this fix, they pass either way.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
This commit is contained in:
Anders Kaseorg 2020-12-09 04:25:11 -08:00 committed by GitHub
parent b4e961148f
commit 4aff7147b5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
tests/test_stepfunctions/test_stepfunctions.py
View File

@ -6,7 +6,7 @@ import os
import sure # noqa import sure # noqa
import sys import sys
from datetime import datetime from datetime import datetime
from dateutil.tz import tzlocal from dateutil.tz import tzutc
from botocore.exceptions import ClientError from botocore.exceptions import ClientError
import pytest import pytest
@ -870,7 +870,7 @@ def test_state_machine_get_execution_history_throws_error_with_unknown_execution
def test_state_machine_get_execution_history_contains_expected_success_events_when_started(): def test_state_machine_get_execution_history_contains_expected_success_events_when_started():
expected_events = [ expected_events = [
{ {
"timestamp": datetime(2020, 1, 1, 0, 0, 0, tzinfo=tzlocal()), "timestamp": datetime(2020, 1, 1, 0, 0, 0, tzinfo=tzutc()),
"type": "ExecutionStarted", "type": "ExecutionStarted",
"id": 1, "id": 1,
"previousEventId": 0, "previousEventId": 0,
@ -881,7 +881,7 @@ def test_state_machine_get_execution_history_contains_expected_success_events_wh
}, },
}, },
{ {
"timestamp": datetime(2020, 1, 1, 0, 0, 10, tzinfo=tzlocal()), "timestamp": datetime(2020, 1, 1, 0, 0, 10, tzinfo=tzutc()),
"type": "PassStateEntered", "type": "PassStateEntered",
"id": 2, "id": 2,
"previousEventId": 0, "previousEventId": 0,
@ -892,7 +892,7 @@ def test_state_machine_get_execution_history_contains_expected_success_events_wh
}, },
}, },
{ {
"timestamp": datetime(2020, 1, 1, 0, 0, 10, tzinfo=tzlocal()), "timestamp": datetime(2020, 1, 1, 0, 0, 10, tzinfo=tzutc()),
"type": "PassStateExited", "type": "PassStateExited",
"id": 3, "id": 3,
"previousEventId": 2, "previousEventId": 2,
@ -903,7 +903,7 @@ def test_state_machine_get_execution_history_contains_expected_success_events_wh
}, },
}, },
{ {
"timestamp": datetime(2020, 1, 1, 0, 0, 20, tzinfo=tzlocal()), "timestamp": datetime(2020, 1, 1, 0, 0, 20, tzinfo=tzutc()),
"type": "ExecutionSucceeded", "type": "ExecutionSucceeded",
"id": 4, "id": 4,
"previousEventId": 3, "previousEventId": 3,
@ -936,7 +936,7 @@ def test_state_machine_get_execution_history_contains_expected_failure_events_wh
raise SkipTest("Cant pass environment variable in server mode") raise SkipTest("Cant pass environment variable in server mode")
expected_events = [ expected_events = [
{ {
"timestamp": datetime(2020, 1, 1, 0, 0, 0, tzinfo=tzlocal()), "timestamp": datetime(2020, 1, 1, 0, 0, 0, tzinfo=tzutc()),
"type": "ExecutionStarted", "type": "ExecutionStarted",
"id": 1, "id": 1,
"previousEventId": 0, "previousEventId": 0,
@ -947,7 +947,7 @@ def test_state_machine_get_execution_history_contains_expected_failure_events_wh
}, },
}, },
{ {
"timestamp": datetime(2020, 1, 1, 0, 0, 10, tzinfo=tzlocal()), "timestamp": datetime(2020, 1, 1, 0, 0, 10, tzinfo=tzutc()),
"type": "FailStateEntered", "type": "FailStateEntered",
"id": 2, "id": 2,
"previousEventId": 0, "previousEventId": 0,
@ -958,7 +958,7 @@ def test_state_machine_get_execution_history_contains_expected_failure_events_wh
}, },
}, },
{ {
"timestamp": datetime(2020, 1, 1, 0, 0, 10, tzinfo=tzlocal()), "timestamp": datetime(2020, 1, 1, 0, 0, 10, tzinfo=tzutc()),
"type": "ExecutionFailed", "type": "ExecutionFailed",
"id": 3, "id": 3,
"previousEventId": 2, "previousEventId": 2,