Yasuke/moto
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

DynamoDB: Ensure first argument to list_append() exists (#6011)

Browse Source
This commit is contained in:
Bert Blommers 2023-03-04 12:25:48 -01:00 committed by GitHub
parent f6ead48401
commit 57205668ed
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 77 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
moto/dynamodb/parsing/validators.py
View File

@ -15,6 +15,7 @@ from moto.dynamodb.exceptions import (
ProvidedKeyDoesNotExist,
EmptyKeyAttributeException,
UpdateHashRangeKeyException,
MockValidationException,
)
from moto.dynamodb.models.dynamo_type import DynamoType, Item
from moto.dynamodb.models.table import Table
@ -239,6 +240,10 @@ class UpdateExpressionFunctionEvaluator(DepthFirstTraverser): # type: ignore[mi
assert isinstance(result, (DDBTypedValue, NoneExistingPath))
return result
elif function_name == "list_append":
if isinstance(first_arg, NoneExistingPath):
raise MockValidationException(
"The provided expression refers to an attribute that does not exist in the item"
)
first_arg = deepcopy(
self.get_list_from_ddb_typed_value(first_arg, function_name)
)

72
tests/test_dynamodb/exceptions/test_dynamodb_exceptions.py
View File

@ -978,3 +978,75 @@ def test_gsi_key_cannot_be_empty():
err["Message"].should.equal(
"One or more parameter values were invalid: Type mismatch for Index Key hello Expected: S Actual: NULL IndexName: hello-index"
)
@mock_dynamodb
def test_list_append_errors_for_unknown_attribute_value():
# Verify whether the list_append operation works as expected
client = boto3.client("dynamodb", region_name="us-east-1")
client.create_table(
AttributeDefinitions=[{"AttributeName": "key", "AttributeType": "S"}],
TableName="table2",
KeySchema=[{"AttributeName": "key", "KeyType": "HASH"}],
ProvisionedThroughput={"ReadCapacityUnits": 5, "WriteCapacityUnits": 5},
)
client.put_item(
TableName="table2",
Item={"key": {"S": "sha-of-file"}, "crontab": {"L": [{"S": "bar1"}]}},
)
# append to unknown list directly
with pytest.raises(ClientError) as exc:
client.update_item(
TableName="table2",
Key={"key": {"S": "sha-of-file"}},
UpdateExpression="SET uk = list_append(uk, :i)",
ExpressionAttributeValues={":i": {"L": [{"S": "bar2"}]}},
ReturnValues="UPDATED_NEW",
)
err = exc.value.response["Error"]
err["Code"].should.equal("ValidationException")
err["Message"].should.equal(
"The provided expression refers to an attribute that does not exist in the item"
)
# append to unknown list via ExpressionAttributeNames
with pytest.raises(ClientError) as exc:
client.update_item(
TableName="table2",
Key={"key": {"S": "sha-of-file"}},
UpdateExpression="SET #0 = list_append(#0, :i)",
ExpressionAttributeNames={"#0": "uk"},
ExpressionAttributeValues={":i": {"L": [{"S": "bar2"}]}},
ReturnValues="UPDATED_NEW",
)
err = exc.value.response["Error"]
err["Code"].should.equal("ValidationException")
err["Message"].should.equal(
"The provided expression refers to an attribute that does not exist in the item"
)
# append to unknown list, even though end result is known
with pytest.raises(ClientError) as exc:
client.update_item(
TableName="table2",
Key={"key": {"S": "sha-of-file"}},
UpdateExpression="SET crontab = list_append(uk, :i)",
ExpressionAttributeValues={":i": {"L": [{"S": "bar2"}]}},
ReturnValues="UPDATED_NEW",
)
err = exc.value.response["Error"]
err["Code"].should.equal("ValidationException")
err["Message"].should.equal(
"The provided expression refers to an attribute that does not exist in the item"
)
# We can append to a known list, into an unknown/new list
client.update_item(
TableName="table2",
Key={"key": {"S": "sha-of-file"}},
UpdateExpression="SET uk = list_append(crontab, :i)",
ExpressionAttributeValues={":i": {"L": [{"S": "bar2"}]}},
ReturnValues="UPDATED_NEW",
)