Yasuke/moto
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix:update rule (#3734)

Browse Source 
* Fix:SQS-message retention period consideration

* Fix:SQS-message retention period consideration

* Fix:SQS-message retention period consideration

* Added comments &linting

* Fixed tests

* Fix:update rule

* Linting and comments
This commit is contained in:
usmangani1 2021-03-02 14:31:09 +05:30 committed by GitHub
parent 457402fbe2
commit 5c04a4d8cc
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 46 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
moto/events/models.py
View File

@ -672,10 +672,22 @@ class EventsBackend(BaseBackend):
return return_obj return return_obj
def update_rule(self, rule, **kwargs):
rule.event_pattern = kwargs.get("EventPattern") or rule.event_pattern
rule.schedule_exp = kwargs.get("ScheduleExpression") or rule.schedule_exp
rule.state = kwargs.get("State") or rule.state
rule.description = kwargs.get("Description") or rule.description
rule.role_arn = kwargs.get("RoleArn") or rule.role_arn
rule.event_bus_name = kwargs.get("EventBusName") or rule.event_bus_name
def put_rule(self, name, **kwargs): def put_rule(self, name, **kwargs):
new_rule = Rule(name, self.region_name, **kwargs) if name in self.rules:
self.rules[new_rule.name] = new_rule self.update_rule(self.rules[name], **kwargs)
self.rules_order.append(new_rule.name) new_rule = self.rules[name]
else:
new_rule = Rule(name, self.region_name, **kwargs)
self.rules[new_rule.name] = new_rule
self.rules_order.append(new_rule.name)
return new_rule return new_rule
def put_targets(self, name, targets): def put_targets(self, name, targets):

31
tests/test_events/test_events.py
View File

@ -208,6 +208,37 @@ def test_remove_targets():
assert targets_before - 1 == targets_after assert targets_before - 1 == targets_after
@mock_events
def test_update_rule_with_targets():
client = boto3.client("events", "us-west-2")
client.put_rule(
Name="test1", ScheduleExpression="rate(5 minutes)", EventPattern="",
)
client.put_targets(
Rule="test1",
Targets=[
{
"Id": "test-target-1",
"Arn": "arn:aws:lambda:us-west-2:111111111111:function:test-function-1",
}
],
)
targets = client.list_targets_by_rule(Rule="test1")["Targets"]
targets_before = len(targets)
assert targets_before == 1
client.put_rule(
Name="test1", ScheduleExpression="rate(1 minute)", EventPattern="",
)
targets = client.list_targets_by_rule(Rule="test1")["Targets"]
assert len(targets) == 1
assert targets[0].get("Id") == "test-target-1"
@mock_events @mock_events
def test_remove_targets_errors(): def test_remove_targets_errors():
client = boto3.client("events", "us-east-1") client = boto3.client("events", "us-east-1")