Yasuke/moto
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #1911 from markchalloner/cf-create-change-sets-tags-fix

Browse Source 
Fix Tags parameter on CloudFormation create_change_set method.
This commit is contained in:
Steve Pulec 2018-12-28 19:55:36 -05:00 committed by GitHub
commit 643c498d01
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
moto/cloudformation/responses.py
View File

@ -87,7 +87,8 @@ class CloudFormationResponse(BaseResponse):
role_arn = self._get_param('RoleARN')
update_or_create = self._get_param('ChangeSetType', 'CREATE')
parameters_list = self._get_list_prefix("Parameters.member")
tags = {tag[0]: tag[1] for tag in self._get_list_prefix("Tags.member")}
tags = dict((item['key'], item['value'])
for item in self._get_list_prefix("Tags.member"))
parameters = {param['parameter_key']: param['parameter_value']
for param in parameters_list}
if template_url:

3
tests/test_cloudformation/test_cloudformation_stack_crud_boto3.py
View File

@ -391,6 +391,9 @@ def test_create_change_set_from_s3_url():
TemplateURL=key_url,
ChangeSetName='NewChangeSet',
ChangeSetType='CREATE',
Tags=[
{'Key': 'tag-key', 'Value': 'tag-value'}
],
)
assert 'arn:aws:cloudformation:us-west-1:123456789:changeSet/NewChangeSet/' in response['Id']
assert 'arn:aws:cloudformation:us-east-1:123456789:stack/NewStack' in response['StackId']