From 7ee35a8510eff9d6a3c3385c8a8cf18c1819c712 Mon Sep 17 00:00:00 2001
From: Kiyonori Matsumoto <kiyonori.matsumoto@gmail.com>
Date: Mon, 16 Sep 2019 23:33:52 +0900
Subject: [PATCH] fix: raises ValueError on conditional and operator

if lhs evaluates to false, rhs must be ignored, but rhs was evaluated then ValueError is occurred.
---
 moto/dynamodb2/comparisons.py         |  3 +--
 tests/test_dynamodb2/test_dynamodb.py | 30 +++++++++++++++++++++++++++
 2 files changed, 31 insertions(+), 2 deletions(-)

diff --git a/moto/dynamodb2/comparisons.py b/moto/dynamodb2/comparisons.py
index 151a314f1..dbc0bd57d 100644
--- a/moto/dynamodb2/comparisons.py
+++ b/moto/dynamodb2/comparisons.py
@@ -941,8 +941,7 @@ class OpAnd(Op):
 
     def expr(self, item):
         lhs = self.lhs.expr(item)
-        rhs = self.rhs.expr(item)
-        return lhs and rhs
+        return lhs and self.rhs.expr(item)
 
 
 class OpLessThan(Op):
diff --git a/tests/test_dynamodb2/test_dynamodb.py b/tests/test_dynamodb2/test_dynamodb.py
index fb6c0e17d..ba5c256c3 100644
--- a/tests/test_dynamodb2/test_dynamodb.py
+++ b/tests/test_dynamodb2/test_dynamodb.py
@@ -2034,6 +2034,36 @@ def test_condition_expression__or_order():
     )
 
 
+@mock_dynamodb2
+def test_condition_expression__and_order():
+    client = boto3.client('dynamodb', region_name='us-east-1')
+
+    client.create_table(
+        TableName='test',
+        KeySchema=[{'AttributeName': 'forum_name', 'KeyType': 'HASH'}],
+        AttributeDefinitions=[
+            {'AttributeName': 'forum_name', 'AttributeType': 'S'},
+        ],
+        ProvisionedThroughput={'ReadCapacityUnits': 1, 'WriteCapacityUnits': 1},
+    )
+    
+    # ensure that the RHS of the AND expression is not evaluated if the LHS
+    # returns true (as it would result an error)
+    with assert_raises(client.exceptions.ConditionalCheckFailedException):
+        client.update_item(
+            TableName='test',
+            Key={
+                'forum_name': {'S': 'the-key'},
+            },
+            UpdateExpression='set #ttl=:ttl',
+            ConditionExpression='attribute_exists(#ttl) AND #ttl <= :old_ttl',
+            ExpressionAttributeNames={'#ttl': 'ttl'},
+            ExpressionAttributeValues={
+                ':ttl': {'N': '6'},
+                ':old_ttl': {'N': '5'},
+            }
+        )
+
 @mock_dynamodb2
 def test_query_gsi_with_range_key():
     dynamodb = boto3.client('dynamodb', region_name='us-east-1')