Yasuke/moto
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

all tests passing

Browse Source
This commit is contained in:
Alex Bainbridge 2020-06-30 12:39:52 -04:00
parent bdc1e93a4f
commit 82825787db
2 changed files with 179 additions and 67 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
moto/ssm/models.py
View File

@ -475,7 +475,7 @@ class SimpleSystemManagerBackend(BaseBackend):
"Status": ssm_document.status, "Status": ssm_document.status,
"Content": ssm_document.content, "Content": ssm_document.content,
"DocumentType": ssm_document.document_type, "DocumentType": ssm_document.document_type,
"DocumentFormat": ssm_document.document_format "DocumentFormat": document_format
} }
if document_format == "JSON": if document_format == "JSON":
@ -555,8 +555,13 @@ class SimpleSystemManagerBackend(BaseBackend):
if document_version or version_name: if document_version or version_name:
# We delete only a specific version # We delete only a specific version
delete_doc = self._find_document(name, document_version, version_name) delete_doc = self._find_document(name, document_version, version_name)
# we can't delete only the default version
if delete_doc and delete_doc.document_version == default_version and len(documents) != 1:
raise InvalidDocumentOperation("Default version of the document can't be deleted.")
if delete_doc: if delete_doc:
keys_to_delete.add(document_version) keys_to_delete.add(delete_doc.document_version)
else: else:
raise InvalidDocument("The specified document does not exist.") raise InvalidDocument("The specified document does not exist.")
else: else:
@ -564,10 +569,20 @@ class SimpleSystemManagerBackend(BaseBackend):
keys_to_delete = set(documents.keys()) keys_to_delete = set(documents.keys())
for key in keys_to_delete: for key in keys_to_delete:
self._documents[name]["documents"][key] = None del self._documents[name]["documents"][key]
keys = self._documents[name]["documents"].keys()
if len(self._documents[name]["documents"].keys()) == 0: if len(self._documents[name]["documents"].keys()) == 0:
self._documents[name] = None del self._documents[name]
else:
old_latest = self._documents[name]["latest_version"]
if old_latest not in self._documents[name]["documents"].keys():
leftover_keys = self._documents[name]["documents"].keys()
int_keys = []
for key in leftover_keys:
int_keys.append(int(key))
self._documents[name]["latest_version"] = str(sorted(int_keys)[-1])
else: else:
raise InvalidDocument("The specified document does not exist.") raise InvalidDocument("The specified document does not exist.")

223
tests/test_ssm/test_ssm_docs.py
View File

@ -98,6 +98,19 @@ def _validate_document_description(doc_name, doc_description, json_doc, expected
doc_description["DefaultVersion"].should.equal(expected_default_version) doc_description["DefaultVersion"].should.equal(expected_default_version)
doc_description["DocumentFormat"].should.equal(expected_format) doc_description["DocumentFormat"].should.equal(expected_format)
def _get_doc_validator(response, version_name, doc_version, json_doc_content, document_format):
response["Name"].should.equal("TestDocument3")
if version_name:
response["VersionName"].should.equal(version_name)
response["DocumentVersion"].should.equal(doc_version)
response["Status"].should.equal("Active")
if document_format == "JSON":
json.loads(response["Content"]).should.equal(json_doc_content)
else:
yaml.safe_load(response["Content"]).should.equal(json_doc_content)
response["DocumentType"].should.equal("Command")
response["DocumentFormat"].should.equal(document_format)
# Done # Done
@mock_ssm @mock_ssm
def test_create_document(): def test_create_document():
@ -129,7 +142,7 @@ def test_create_document():
_validate_document_description("TestDocument3", doc_description, json_doc, "1", "1", "1", "JSON") _validate_document_description("TestDocument3", doc_description, json_doc, "1", "1", "1", "JSON")
# Done
@mock_ssm @mock_ssm
def test_get_document(): def test_get_document():
template_file = _get_yaml_template() template_file = _get_yaml_template()
@ -149,40 +162,59 @@ def test_get_document():
VersionName="Base" VersionName="Base"
) )
new_json_doc = copy.copy(json_doc)
new_json_doc['description'] = "a new description"
client.update_document(
Content=json.dumps(new_json_doc), Name="TestDocument3", DocumentVersion="$LATEST", VersionName="NewBase"
)
response = client.get_document(Name="TestDocument3") response = client.get_document(Name="TestDocument3")
response["Name"].should.equal("TestDocument3") _get_doc_validator(response, "Base", "1", json_doc, "JSON")
response["VersionName"].should.equal("Base")
response["DocumentVersion"].should.equal("1")
response["Status"].should.equal("Active")
response["Content"].should.equal(yaml.dump(json_doc))
response["DocumentType"].should.equal("Command")
response["DocumentFormat"].should.equal("YAML")
response = client.get_document(Name="TestDocument3", DocumentFormat="YAML") response = client.get_document(Name="TestDocument3", DocumentFormat="YAML")
response["Name"].should.equal("TestDocument3") _get_doc_validator(response, "Base", "1", json_doc, "YAML")
response["VersionName"].should.equal("Base")
response["DocumentVersion"].should.equal("1")
response["Status"].should.equal("Active")
response["Content"].should.equal(yaml.dump(json_doc))
response["DocumentType"].should.equal("Command")
response["DocumentFormat"].should.equal("YAML")
response = client.get_document(Name="TestDocument3", DocumentFormat="JSON") response = client.get_document(Name="TestDocument3", DocumentFormat="JSON")
response["Name"].should.equal("TestDocument3") _get_doc_validator(response, "Base", "1", json_doc, "JSON")
response["VersionName"].should.equal("Base")
response["DocumentVersion"].should.equal("1")
response["Status"].should.equal("Active")
response["Content"].should.equal(json.dumps(json_doc))
response["DocumentType"].should.equal("Command")
response["DocumentFormat"].should.equal("JSON")
# response = client.get_document(Name="TestDocument3", VersionName="Base") response = client.get_document(Name="TestDocument3", VersionName="Base")
# response = client.get_document(Name="TestDocument3", DocumentVersion="1") _get_doc_validator(response, "Base", "1", json_doc, "JSON")
# response = client.get_document(Name="TestDocument3", DocumentVersion="2") response = client.get_document(Name="TestDocument3", DocumentVersion="1")
# response = client.get_document(Name="TestDocument3", VersionName="Base", DocumentVersion="2") _get_doc_validator(response, "Base", "1", json_doc, "JSON")
# response = client.get_document(Name="TestDocument3", DocumentFormat="YAML")
# response = client.get_document(Name="TestDocument3", DocumentFormat="JSON") response = client.get_document(Name="TestDocument3", DocumentVersion="2")
_get_doc_validator(response, "NewBase", "2", new_json_doc, "JSON")
response = client.get_document(Name="TestDocument3", VersionName="NewBase")
_get_doc_validator(response, "NewBase", "2", new_json_doc, "JSON")
response = client.get_document(Name="TestDocument3", VersionName="NewBase", DocumentVersion="2")
_get_doc_validator(response, "NewBase", "2", new_json_doc, "JSON")
try:
response = client.get_document(Name="TestDocument3", VersionName="BadName", DocumentVersion="2")
raise RuntimeError("Should fail")
except botocore.exceptions.ClientError as err:
err.operation_name.should.equal("GetDocument")
err.response["Error"]["Message"].should.equal("The specified document does not exist.")
try:
response = client.get_document(Name="TestDocument3", DocumentVersion="3")
raise RuntimeError("Should fail")
except botocore.exceptions.ClientError as err:
err.operation_name.should.equal("GetDocument")
err.response["Error"]["Message"].should.equal("The specified document does not exist.")
# Updating default should update normal get
client.update_document_default_version(
Name="TestDocument3",
DocumentVersion="2"
)
response = client.get_document(Name="TestDocument3", DocumentFormat="JSON")
_get_doc_validator(response, "NewBase", "2", new_json_doc, "JSON")
@mock_ssm @mock_ssm
def test_delete_document(): def test_delete_document():
@ -190,48 +222,113 @@ def test_delete_document():
json_doc = yaml.safe_load(template_file) json_doc = yaml.safe_load(template_file)
client = boto3.client("ssm", region_name="us-east-1") client = boto3.client("ssm", region_name="us-east-1")
try:
client.delete_document(Name="DNE")
raise RuntimeError("Should fail")
except botocore.exceptions.ClientError as err:
err.operation_name.should.equal("DeleteDocument")
err.response["Error"]["Message"].should.equal("The specified document does not exist.")
# Test simple # Test simple
client.create_document( client.create_document(
Content=yaml.dump(json_doc), Name="TestDocument3", DocumentType="Command", DocumentFormat="YAML", Content=yaml.dump(json_doc), Name="TestDocument3", DocumentType="Command", DocumentFormat="YAML",
VersionName="Base", TargetType="/AWS::EC2::Instance" VersionName="Base", TargetType="/AWS::EC2::Instance"
) )
response = client.delete_document(Name="TestDocument3") client.delete_document(Name="TestDocument3")
# response = client.get_document(Name="TestDocument3")
#
# # Test re-use
# client.create_document(
# Content=yaml.dump(json_doc), Name="TestDocument3", DocumentType="Command", DocumentFormat="YAML",
# VersionName="Base", TargetType="/AWS::EC2::Instance"
# )
# response = client.get_document(Name="TestDocument3")
# updates try:
client.get_document(Name="TestDocument3")
raise RuntimeError("Should fail")
except botocore.exceptions.ClientError as err:
err.operation_name.should.equal("GetDocument")
err.response["Error"]["Message"].should.equal("The specified document does not exist.")
# We update default_version here to test some other cases around deleting specific versions
# response = client.update_document_default_version( # Delete default version with other version is bad
# Name="TestDocument3", client.create_document(
# DocumentVersion=2 Content=yaml.dump(json_doc), Name="TestDocument3", DocumentType="Command", DocumentFormat="YAML",
# ) VersionName="Base", TargetType="/AWS::EC2::Instance"
# )
# response = client.delete_document(Name="TestDocument3", DocumentVersion="4")
# response = client.get_document(Name="TestDocument3") new_json_doc = copy.copy(json_doc)
# response = client.get_document(Name="TestDocument3", DocumentVersion="4") new_json_doc['description'] = "a new description"
#
# # Both filters should match in order to delete client.update_document(
# response = client.delete_document(Name="TestDocument3", DocumentVersion="1", VersionName="NotVersion") Content=json.dumps(new_json_doc), Name="TestDocument3", DocumentVersion="$LATEST", VersionName="NewBase"
# response = client.get_document(Name="TestDocument3") )
# response = client.get_document(Name="TestDocument3", DocumentVersion="1")
# new_json_doc['description'] = "a new description2"
# response = client.delete_document(Name="TestDocument3", DocumentVersion="1", VersionName="RealVersion") client.update_document(
# response = client.get_document(Name="TestDocument3") Content=json.dumps(new_json_doc), Name="TestDocument3", DocumentVersion="$LATEST"
# response = client.get_document(Name="TestDocument3", DocumentVersion="1") )
#
# # AWS doesn't allow deletion of default version if other versions are left new_json_doc['description'] = "a new description3"
# response = client.delete_document(Name="TestDocument3", DocumentVersion="2") client.update_document(
# Content=json.dumps(new_json_doc), Name="TestDocument3", DocumentVersion="$LATEST"
# response = client.delete_document(Name="TestDocument3") )
# response = client.get_document(Name="TestDocument3")
# response = client.get_document(Name="TestDocument3", DocumentVersion="3") new_json_doc['description'] = "a new description4"
client.update_document(
Content=json.dumps(new_json_doc), Name="TestDocument3", DocumentVersion="$LATEST"
)
try:
client.delete_document(Name="TestDocument3", DocumentVersion="1")
raise RuntimeError("Should fail")
except botocore.exceptions.ClientError as err:
err.operation_name.should.equal("DeleteDocument")
err.response["Error"]["Message"].should.equal("Default version of the document can't be deleted.")
try:
client.delete_document(Name="TestDocument3", VersionName="Base")
raise RuntimeError("Should fail")
except botocore.exceptions.ClientError as err:
err.operation_name.should.equal("DeleteDocument")
err.response["Error"]["Message"].should.equal("Default version of the document can't be deleted.")
# Make sure no ill side effects
response = client.get_document(Name="TestDocument3")
_get_doc_validator(response, "Base", "1", json_doc, "JSON")
client.delete_document(Name="TestDocument3", DocumentVersion="5")
# Check that latest version is changed
response = client.describe_document(Name="TestDocument3")
response["Document"]["LatestVersion"].should.equal("4")
client.delete_document(Name="TestDocument3", VersionName="NewBase")
# Make sure other versions okay
client.get_document(Name="TestDocument3", DocumentVersion="1")
client.get_document(Name="TestDocument3", DocumentVersion="3")
client.get_document(Name="TestDocument3", DocumentVersion="4")
client.delete_document(Name="TestDocument3")
try:
client.get_document(Name="TestDocument3", DocumentVersion="1")
raise RuntimeError("Should fail")
except botocore.exceptions.ClientError as err:
err.operation_name.should.equal("GetDocument")
err.response["Error"]["Message"].should.equal("The specified document does not exist.")
try:
client.get_document(Name="TestDocument3", DocumentVersion="3")
raise RuntimeError("Should fail")
except botocore.exceptions.ClientError as err:
err.operation_name.should.equal("GetDocument")
err.response["Error"]["Message"].should.equal("The specified document does not exist.")
try:
client.get_document(Name="TestDocument3", DocumentVersion="4")
raise RuntimeError("Should fail")
except botocore.exceptions.ClientError as err:
err.operation_name.should.equal("GetDocument")
err.response["Error"]["Message"].should.equal("The specified document does not exist.")
response = client.list_documents()
len(response['DocumentIdentifiers']).should.equal(0)
# Done # Done
@mock_ssm @mock_ssm