Move *Type __repr__ to GenericType

This commit is contained in:
Jean-Baptiste Barth 2015-10-02 03:37:14 +02:00
parent 080b79338d
commit 8b02c0b85e
2 changed files with 9 additions and 6 deletions

View File

@ -73,6 +73,11 @@ class GenericType(object):
for key, value in kwargs.iteritems():
self.__setattr__(key, value)
def __repr__(self):
cls = self.__class__.__name__
attrs = "name: %(name)s, version: %(version)s" % self.__dict__
return "{}({})".format(cls, attrs)
@property
def kind(self):
raise NotImplementedError()
@ -116,9 +121,6 @@ class GenericType(object):
return hsh
class ActivityType(GenericType):
def __repr__(self):
return "ActivityType(name: %(name)s, version: %(version)s)" % self.__dict__
@property
def _configuration_keys(self):
return [
@ -134,9 +136,6 @@ class ActivityType(GenericType):
class WorkflowType(GenericType):
def __repr__(self):
return "WorkflowType(name: %(name)s, version: %(version)s)" % self.__dict__
@property
def _configuration_keys(self):
return [

View File

@ -44,3 +44,7 @@ def test_full_dict_representation():
_type.non_whitelisted_property = "34"
_type.to_full_dict()["configuration"].keys().should.equal(["defaultTaskList", "justAnExampleTimeout"])
def test_string_representation():
_type = FooType("test-foo", "v1.0")
str(_type).should.equal("FooType(name: test-foo, version: v1.0)")