Yasuke/moto
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Techdebt: Replace sure with regular assertions in ElasticBeanstalk (#6544)

Browse Source
This commit is contained in:
Bert Blommers 2023-07-20 09:36:51 +00:00 committed by GitHub
parent a0af77f32c
commit 8db8556562
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 20 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

41
tests/test_elasticbeanstalk/test_eb.py
View File

@ -1,5 +1,5 @@
import boto3 import boto3
import sure # noqa # pylint: disable=unused-import import pytest
from botocore.exceptions import ClientError from botocore.exceptions import ClientError
from moto import mock_elasticbeanstalk from moto import mock_elasticbeanstalk
@ -10,17 +10,16 @@ def test_create_application():
# Create Elastic Beanstalk Application # Create Elastic Beanstalk Application
conn = boto3.client("elasticbeanstalk", region_name="us-east-1") conn = boto3.client("elasticbeanstalk", region_name="us-east-1")
app = conn.create_application(ApplicationName="myapp") app = conn.create_application(ApplicationName="myapp")
app["Application"]["ApplicationName"].should.equal("myapp") assert app["Application"]["ApplicationName"] == "myapp"
app["Application"]["ApplicationArn"].should.contain("myapp") assert "myapp" in app["Application"]["ApplicationArn"]
@mock_elasticbeanstalk @mock_elasticbeanstalk
def test_create_application_dup(): def test_create_application_dup():
conn = boto3.client("elasticbeanstalk", region_name="us-east-1") conn = boto3.client("elasticbeanstalk", region_name="us-east-1")
conn.create_application(ApplicationName="myapp") conn.create_application(ApplicationName="myapp")
conn.create_application.when.called_with(ApplicationName="myapp").should.throw( with pytest.raises(ClientError):
ClientError conn.create_application(ApplicationName="myapp")
)
@mock_elasticbeanstalk @mock_elasticbeanstalk
@ -30,9 +29,9 @@ def test_describe_applications():
conn.create_application(ApplicationName="myapp") conn.create_application(ApplicationName="myapp")
apps = conn.describe_applications() apps = conn.describe_applications()
len(apps["Applications"]).should.equal(1) assert len(apps["Applications"]) == 1
apps["Applications"][0]["ApplicationName"].should.equal("myapp") assert apps["Applications"][0]["ApplicationName"] == "myapp"
apps["Applications"][0]["ApplicationArn"].should.contain("myapp") assert "myapp" in apps["Applications"][0]["ApplicationArn"]
@mock_elasticbeanstalk @mock_elasticbeanstalk
@ -41,8 +40,8 @@ def test_create_environment():
conn = boto3.client("elasticbeanstalk", region_name="us-east-1") conn = boto3.client("elasticbeanstalk", region_name="us-east-1")
conn.create_application(ApplicationName="myapp") conn.create_application(ApplicationName="myapp")
env = conn.create_environment(ApplicationName="myapp", EnvironmentName="myenv") env = conn.create_environment(ApplicationName="myapp", EnvironmentName="myenv")
env["EnvironmentName"].should.equal("myenv") assert env["EnvironmentName"] == "myenv"
env["EnvironmentArn"].should.contain("myapp/myenv") assert "myapp/myenv" in env["EnvironmentArn"]
@mock_elasticbeanstalk @mock_elasticbeanstalk
@ -54,10 +53,10 @@ def test_describe_environments():
envs = conn.describe_environments() envs = conn.describe_environments()
envs = envs["Environments"] envs = envs["Environments"]
len(envs).should.equal(1) assert len(envs) == 1
envs[0]["ApplicationName"].should.equal("myapp") assert envs[0]["ApplicationName"] == "myapp"
envs[0]["EnvironmentName"].should.equal("myenv") assert envs[0]["EnvironmentName"] == "myenv"
envs[0]["EnvironmentArn"].should.contain("myapp/myenv") assert "myapp/myenv" in envs[0]["EnvironmentArn"]
def tags_dict_to_list(tag_dict): def tags_dict_to_list(tag_dict):
@ -86,8 +85,8 @@ def test_create_environment_tags():
) )
tags = conn.list_tags_for_resource(ResourceArn=env["EnvironmentArn"]) tags = conn.list_tags_for_resource(ResourceArn=env["EnvironmentArn"])
tags["ResourceArn"].should.equal(env["EnvironmentArn"]) assert tags["ResourceArn"] == env["EnvironmentArn"]
tags_list_to_dict(tags["ResourceTags"]).should.equal(env_tags) assert tags_list_to_dict(tags["ResourceTags"]) == env_tags
@mock_elasticbeanstalk @mock_elasticbeanstalk
@ -120,13 +119,13 @@ def test_update_tags():
del total_env_tags["to remove"] del total_env_tags["to remove"]
tags = conn.list_tags_for_resource(ResourceArn=env["EnvironmentArn"]) tags = conn.list_tags_for_resource(ResourceArn=env["EnvironmentArn"])
tags["ResourceArn"].should.equal(env["EnvironmentArn"]) assert tags["ResourceArn"] == env["EnvironmentArn"]
tags_list_to_dict(tags["ResourceTags"]).should.equal(total_env_tags) assert tags_list_to_dict(tags["ResourceTags"]) == total_env_tags
@mock_elasticbeanstalk @mock_elasticbeanstalk
def test_list_available_solution_stacks(): def test_list_available_solution_stacks():
conn = boto3.client("elasticbeanstalk", region_name="us-east-1") conn = boto3.client("elasticbeanstalk", region_name="us-east-1")
stacks = conn.list_available_solution_stacks() stacks = conn.list_available_solution_stacks()
len(stacks["SolutionStacks"]).should.be.greater_than(0) assert len(stacks["SolutionStacks"]) > 0
len(stacks["SolutionStacks"]).should.be.equal(len(stacks["SolutionStackDetails"])) assert len(stacks["SolutionStacks"]) == len(stacks["SolutionStackDetails"])