Yasuke/moto
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Refactor tests marked xfail to use proper assertions (#3515)

Browse Source
This commit is contained in:
Brian Pandola 2020-12-04 08:00:48 -08:00 committed by GitHub
parent dcd034045b
commit 8f83f51897
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
tests/test_iam/test_iam.py
View File

@ -134,19 +134,21 @@ def test_delete_server_cert():
@mock_iam_deprecated() @mock_iam_deprecated()
@pytest.mark.xfail(raises=BotoServerError)
def test_get_role__should_throw__when_role_does_not_exist(): def test_get_role__should_throw__when_role_does_not_exist():
conn = boto.connect_iam() conn = boto.connect_iam()
with pytest.raises(BotoServerError) as ex:
conn.get_role("unexisting_role") conn.get_role("unexisting_role")
ex.value.error_code.should.equal("NoSuchEntity")
ex.value.message.should.contain("not found")
@mock_iam_deprecated() @mock_iam_deprecated()
@pytest.mark.xfail(raises=BotoServerError)
def test_get_instance_profile__should_throw__when_instance_profile_does_not_exist(): def test_get_instance_profile__should_throw__when_instance_profile_does_not_exist():
conn = boto.connect_iam() conn = boto.connect_iam()
with pytest.raises(BotoServerError) as ex:
conn.get_instance_profile("unexisting_instance_profile") conn.get_instance_profile("unexisting_instance_profile")
ex.value.error_code.should.equal("NoSuchEntity")
ex.value.message.should.contain("not found")
@mock_iam_deprecated() @mock_iam_deprecated()