Yasuke/moto
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Issue 1753: Add support for DescribeSecret

Browse Source 
- Add helper method to validate the secret identifier from the client.
- Update describe_secret to use new helper method.
- Insert friendly name into "Name" field of returned description (was
SecretId). ***Assumes acceptance of PR 1772.
This commit is contained in:
Neil Roberts 2018-08-13 12:41:43 -07:00
parent b47fc74650
commit 92bc3ff910
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
moto/secretsmanager/models.py
View File

@ -42,6 +42,9 @@ class SecretsManagerBackend(BaseBackend):
self.__dict__ = {} self.__dict__ = {}
self.__init__(region_name) self.__init__(region_name)
def _is_valid_identifier(self, identifier):
return identifier in (self.name, self.secret_id)
def get_secret_value(self, secret_id, version_id, version_stage): def get_secret_value(self, secret_id, version_id, version_stage):
if self.secret_id == '': if self.secret_id == '':
@ -74,12 +77,12 @@ class SecretsManagerBackend(BaseBackend):
return response return response
def describe_secret(self, secret_id): def describe_secret(self, secret_id):
if self.secret_id == '': if not self._is_valid_identifier(secret_id):
raise ResourceNotFoundException raise ResourceNotFoundException
response = json.dumps({ response = json.dumps({
"ARN": secret_arn(self.region, self.secret_id), "ARN": secret_arn(self.region, self.secret_id),
"Name": self.secret_id, "Name": self.name,
"Description": "", "Description": "",
"KmsKeyId": "", "KmsKeyId": "",
"RotationEnabled": self.rotation_enabled, "RotationEnabled": self.rotation_enabled,