Yasuke/moto
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Send JSON message to HTTP endpoint of SNS

Browse Source 
By the documentation from AWS -
http://docs.aws.amazon.com/sns/latest/dg/SendMessageToHttp.html ,
SNS would send messages to HTTP/HTTPS endpoint in JSON format. But
current implementation of `moto` sends messages in form-data format.
This commit is contained in:
sodastsai 2017-07-30 20:44:06 +08:00
parent 2564953ce7
commit 92eedcf291
2 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
moto/sns/models.py
View File

@ -84,7 +84,7 @@ class Subscription(BaseModel):
sqs_backends[region].send_message(queue_name, message) sqs_backends[region].send_message(queue_name, message)
elif self.protocol in ['http', 'https']: elif self.protocol in ['http', 'https']:
post_data = self.get_post_data(message, message_id) post_data = self.get_post_data(message, message_id)
requests.post(self.endpoint, data=post_data) requests.post(self.endpoint, json=post_data)
def get_post_data(self, message, message_id): def get_post_data(self, message, message_id):
return { return {

11
tests/test_sns/test_publishing_boto3.py
View File

@ -1,4 +1,7 @@
from __future__ import unicode_literals from __future__ import unicode_literals
import json
from six.moves.urllib.parse import parse_qs from six.moves.urllib.parse import parse_qs
import boto3 import boto3
@ -56,9 +59,15 @@ def test_publish_to_sqs_in_different_region():
@freeze_time("2013-01-01") @freeze_time("2013-01-01")
@mock_sns @mock_sns
def test_publish_to_http(): def test_publish_to_http():
responses.add( def callback(request):
request.headers["Content-Type"].should.equal("application/json")
json.loads.when.called_with(request.body).should_not.throw(Exception)
return 200, {}, ""
responses.add_callback(
method="POST", method="POST",
url="http://example.com/foobar", url="http://example.com/foobar",
callback=callback,
) )
conn = boto3.client('sns', region_name='us-east-1') conn = boto3.client('sns', region_name='us-east-1')