Yasuke/moto
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #1551 from william-richard/add-physical-resource-id-to-ecs-task-definition

Browse Source 
Add physical_resource_id to ECS task definition
This commit is contained in:
Steve Pulec 2018-04-12 18:48:43 -04:00 committed by GitHub
commit 97708fdbed
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
moto/ecs/models.py
View File

@ -109,6 +109,10 @@ class TaskDefinition(BaseObject):
del response_object['arn']
return response_object
@property
def physical_resource_id(self):
return self.arn
@classmethod
def create_from_cloudformation_json(cls, resource_name, cloudformation_json, region_name):
properties = cloudformation_json['Properties']

7
tests/test_ecs/test_ecs_boto3.py
View File

@ -1400,15 +1400,20 @@ def test_create_task_definition_through_cloudformation():
}
template_json = json.dumps(template)
cfn_conn = boto3.client('cloudformation', region_name='us-west-1')
stack_name = 'test_stack'
cfn_conn.create_stack(
StackName="test_stack",
StackName=stack_name,
TemplateBody=template_json,
)
ecs_conn = boto3.client('ecs', region_name='us-west-1')
resp = ecs_conn.list_task_definitions()
len(resp['taskDefinitionArns']).should.equal(1)
task_definition_arn = resp['taskDefinitionArns'][0]
task_definition_details = cfn_conn.describe_stack_resource(
StackName=stack_name,LogicalResourceId='testTaskDefinition')['StackResourceDetail']
task_definition_details['PhysicalResourceId'].should.equal(task_definition_arn)
@mock_ec2
@mock_ecs