Yasuke/moto
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

copy ContentType and Metadata from source object (#4666)

Browse Source
This commit is contained in:
Grisha Kostyuk 2021-12-07 14:14:19 +02:00 committed by GitHub
parent cd5357ca41
commit 9ca50c3474
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 22 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
moto/s3/models.py
View File

@ -2066,6 +2066,7 @@ class S3Backend(BaseBackend, CloudWatchMetricProvider):
lock_until=key.lock_until, lock_until=key.lock_until,
) )
self.tagger.copy_tags(key.arn, new_key.arn) self.tagger.copy_tags(key.arn, new_key.arn)
new_key.set_metadata(key.metadata)
if acl is not None: if acl is not None:
new_key.set_acl(acl) new_key.set_acl(acl)

21
tests/test_s3/test_s3.py
View File

@ -1042,6 +1042,27 @@ def test_copy_key_replace_metadata():
bucket.get_key("new-key").get_metadata("momd").should.equal("Mometadatastring") bucket.get_key("new-key").get_metadata("momd").should.equal("Mometadatastring")
@mock_s3
def test_copy_key_with_metadata_boto3():
s3 = boto3.resource("s3", region_name=DEFAULT_REGION_NAME)
client = boto3.client("s3", region_name=DEFAULT_REGION_NAME)
s3.create_bucket(Bucket="foobar")
key = s3.Object("foobar", "the-key")
metadata = {"md": "Metadatastring"}
content_type = "application/json"
initial = key.put(Body=b"{}", Metadata=metadata, ContentType=content_type)
client.copy_object(
Bucket="foobar", CopySource="foobar/the-key", Key="new-key",
)
resp = client.get_object(Bucket="foobar", Key="new-key")
resp["Metadata"].should.equal(metadata)
resp["ContentType"].should.equal(content_type)
resp["ETag"].should.equal(initial["ETag"])
@mock_s3 @mock_s3
def test_copy_key_replace_metadata_boto3(): def test_copy_key_replace_metadata_boto3():
s3 = boto3.resource("s3", region_name=DEFAULT_REGION_NAME) s3 = boto3.resource("s3", region_name=DEFAULT_REGION_NAME)