TimestreamWrite - list of records should be extended, not appended to (#4860)

This commit is contained in:
Bert Blommers 2022-02-14 19:17:48 -01:00 committed by GitHub
parent e75dcf47b7
commit acc5e60f44
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 28 additions and 3 deletions

View File

@ -14,7 +14,7 @@ class TimestreamTable(BaseModel):
self.retention_properties = retention_properties
def write_records(self, records):
self.records.append(records)
self.records.extend(records)
@property
def arn(self):

View File

@ -1,6 +1,6 @@
import boto3
import sure # noqa # pylint: disable=unused-import
from moto import mock_timestreamwrite
from moto import mock_timestreamwrite, settings
from moto.core import ACCOUNT_ID
@ -179,5 +179,30 @@ def test_write_records():
ts.write_records(
DatabaseName="mydatabase",
TableName="mytable",
Records=[{"Dimensions": [], "MeasureName": "mn", "MeasureValue": "mv"}],
Records=[{"Dimensions": [], "MeasureName": "mn1", "MeasureValue": "mv1"}],
)
if not settings.TEST_SERVER_MODE:
from moto.timestreamwrite.models import timestreamwrite_backends
backend = timestreamwrite_backends["us-east-1"]
records = backend.databases["mydatabase"].tables["mytable"].records
records.should.equal(
[{"Dimensions": [], "MeasureName": "mn1", "MeasureValue": "mv1"}]
)
ts.write_records(
DatabaseName="mydatabase",
TableName="mytable",
Records=[
{"Dimensions": [], "MeasureName": "mn2", "MeasureValue": "mv2"},
{"Dimensions": [], "MeasureName": "mn3", "MeasureValue": "mv3"},
],
)
records.should.equal(
[
{"Dimensions": [], "MeasureName": "mn1", "MeasureValue": "mv1"},
{"Dimensions": [], "MeasureName": "mn2", "MeasureValue": "mv2"},
{"Dimensions": [], "MeasureName": "mn3", "MeasureValue": "mv3"},
]
)