Yasuke/moto
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Docs: mark S3:put_public_access_block() as implemented (#7035)

Browse Source
This commit is contained in:
Bert Blommers 2023-11-16 18:56:58 -01:00 committed by GitHub
parent e7156a7642
commit b54863523b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 6 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
IMPLEMENTATION_COVERAGE.md
View File

@ -6173,7 +6173,7 @@
## s3 ## s3
<details> <details>
<summary>64% implemented</summary> <summary>65% implemented</summary>
- [X] abort_multipart_upload - [X] abort_multipart_upload
- [X] complete_multipart_upload - [X] complete_multipart_upload
@ -6266,7 +6266,7 @@
- [X] put_object_lock_configuration - [X] put_object_lock_configuration
- [X] put_object_retention - [X] put_object_retention
- [ ] put_object_tagging - [ ] put_object_tagging
- [ ] put_public_access_block - [X] put_public_access_block
- [ ] restore_object - [ ] restore_object
- [X] select_object_content - [X] select_object_content
- [X] upload_part - [X] upload_part

2
docs/docs/services/s3.rst
View File

@ -143,7 +143,7 @@ s3
- [X] put_object_lock_configuration - [X] put_object_lock_configuration
- [X] put_object_retention - [X] put_object_retention
- [ ] put_object_tagging - [ ] put_object_tagging
- [ ] put_public_access_block - [X] put_public_access_block
- [ ] restore_object - [ ] restore_object
- [X] select_object_content - [X] select_object_content

2
moto/s3/models.py
View File

@ -2235,7 +2235,7 @@ class S3Backend(BaseBackend, CloudWatchMetricProvider):
raise InvalidRequest("PutBucketAccelerateConfiguration") raise InvalidRequest("PutBucketAccelerateConfiguration")
bucket.set_accelerate_configuration(accelerate_configuration) bucket.set_accelerate_configuration(accelerate_configuration)
def put_bucket_public_access_block( def put_public_access_block(
self, bucket_name: str, pub_block_config: Optional[Dict[str, Any]] self, bucket_name: str, pub_block_config: Optional[Dict[str, Any]]
) -> None: ) -> None:
bucket = self.get_bucket(bucket_name) bucket = self.get_bucket(bucket_name)

2
moto/s3/responses.py
View File

@ -922,7 +922,7 @@ class S3Response(BaseResponse):
elif "publicAccessBlock" in querystring: elif "publicAccessBlock" in querystring:
pab_config = self._parse_pab_config() pab_config = self._parse_pab_config()
self.backend.put_bucket_public_access_block( self.backend.put_public_access_block(
bucket_name, pab_config["PublicAccessBlockConfiguration"] bucket_name, pab_config["PublicAccessBlockConfiguration"]
) )
return "" return ""

4
tests/test_s3/test_s3_config.py
View File

@ -22,9 +22,7 @@ def test_s3_public_access_block_to_config_dict():
} }
# Add a public access block: # Add a public access block:
s3_config_query_backend.put_bucket_public_access_block( s3_config_query_backend.put_public_access_block("bucket1", public_access_block)
"bucket1", public_access_block
)
result = s3_config_query_backend.buckets[ result = s3_config_query_backend.buckets[
"bucket1" "bucket1"