Yasuke/moto
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

SSM Parameter Store Error Message When Requesting Invalid Version (#3977)

Browse Source 
* Implement correct error when requesting specific version of a parameter which exists but does not have this version

* removing trailing whitespace causing lint failure

* Adding unit tests and fixing linting for new error handling

* Fixing small bug in response message

* Revert change in get_parameters as versioning is not currently implemented in this method. Will fix as a separate PR
This commit is contained in:
Austin Hendrix 2021-06-02 10:27:23 -05:00 committed by GitHub
parent 7947b1e001
commit b670962c5e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 14 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
moto/ssm/models.py
View File

@ -1217,7 +1217,12 @@ class SimpleSystemManagerBackend(BaseBackend):
)
if len(result) > 0:
return result[-1]
elif len(parameters) > 0:
raise ParameterVersionNotFound(
"Systems Manager could not find version %s of %s. "
"Verify the version and try again."
% (version_or_label, name_prefix)
)
result = list(
filter(lambda x: version_or_label in x.labels, parameters)
)

9
tests/test_ssm/test_ssm_boto3.py
View File

@ -465,8 +465,15 @@ def test_get_parameter_with_version_and_labels():
with pytest.raises(ClientError) as ex:
client.get_parameter(Name="test-2:2", WithDecryption=False)
ex.value.response["Error"]["Code"].should.equal("ParameterVersionNotFound")
ex.value.response["Error"]["Message"].should.equal(
"Systems Manager could not find version 2 of test-2. Verify the version and try again."
)
with pytest.raises(ClientError) as ex:
client.get_parameter(Name="test-3:2", WithDecryption=False)
ex.value.response["Error"]["Code"].should.equal("ParameterNotFound")
ex.value.response["Error"]["Message"].should.equal("Parameter test-2:2 not found.")
ex.value.response["Error"]["Message"].should.equal("Parameter test-3:2 not found.")
@mock_ssm