Yasuke/moto
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Cognito: Validate password in NEW_PASSWORD_REQUIRED (#6174)

Browse Source
This commit is contained in:
Matthew Burke 2023-04-05 17:15:30 +01:00 committed by GitHub
parent f424c6ac05
commit bbb07b4e7e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
moto/cognitoidp/models.py
View File

@ -1474,6 +1474,9 @@ class CognitoIdpBackend(BaseBackend):
if challenge_name == "NEW_PASSWORD_REQUIRED": if challenge_name == "NEW_PASSWORD_REQUIRED":
username: str = challenge_responses.get("USERNAME") # type: ignore[assignment] username: str = challenge_responses.get("USERNAME") # type: ignore[assignment]
new_password = challenge_responses.get("NEW_PASSWORD") new_password = challenge_responses.get("NEW_PASSWORD")
if not new_password:
raise InvalidPasswordException()
self._validate_password(user_pool.id, new_password)
user = self.admin_get_user(user_pool.id, username) user = self.admin_get_user(user_pool.id, username)
user.password = new_password user.password = new_password

6
tests/test_cognitoidp/test_server.py
View File

@ -132,7 +132,7 @@ def test_admin_create_user_without_authentication():
data = { data = {
"UserPoolId": user_pool_id, "UserPoolId": user_pool_id,
"Username": "test@gmail.com", "Username": "test@gmail.com",
"TemporaryPassword": "12345678", "TemporaryPassword": "A!1a12345678",
} }
res = test_client.post( res = test_client.post(
"/", "/",
@ -148,7 +148,7 @@ def test_admin_create_user_without_authentication():
data = { data = {
"ClientId": client_id, "ClientId": client_id,
"AuthFlow": "USER_PASSWORD_AUTH", "AuthFlow": "USER_PASSWORD_AUTH",
"AuthParameters": {"USERNAME": "test@gmail.com", "PASSWORD": "12345678"}, "AuthParameters": {"USERNAME": "test@gmail.com", "PASSWORD": "A!1a12345678"},
} }
res = test_client.post( res = test_client.post(
"/", "/",
@ -163,7 +163,7 @@ def test_admin_create_user_without_authentication():
"ChallengeName": "NEW_PASSWORD_REQUIRED", "ChallengeName": "NEW_PASSWORD_REQUIRED",
"ChallengeResponses": { "ChallengeResponses": {
"USERNAME": "test@gmail.com", "USERNAME": "test@gmail.com",
"NEW_PASSWORD": "abcdefgh", "NEW_PASSWORD": "A!1aabcdefgh",
}, },
"Session": session, "Session": session,
} }