Yasuke/moto
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix using mutable default arguments.

Browse Source 
According to
http://docs.python-guide.org/en/latest/writing/gotchas/#mutable-default-arguments
using mutable default arguments is not a good practice since it doesn't
perform intuitively. For example lists and dictionaries as default
arguments are initialized ONCE instead of on each invocation of the
function.
This commit is contained in:
Mike Liu 2018-06-11 12:28:11 -04:00
parent a0882316ec
commit bbf70bf21c
1 changed files with 16 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
moto/ssm/models.py
View File

@ -64,10 +64,22 @@ MAX_TIMEOUT_SECONDS = 3600
class Command(BaseModel):
def __init__(self, comment='', document_name='', timeout_seconds=MAX_TIMEOUT_SECONDS,
instance_ids=[], max_concurrency='', max_errors='',
notification_config={}, output_s3_bucket_name='',
output_s3_key_prefix='', output_s3_region='', parameters={},
service_role_arn='', targets=[]):
instance_ids=None, max_concurrency='', max_errors='',
notification_config=None, output_s3_bucket_name='',
output_s3_key_prefix='', output_s3_region='', parameters=None,
service_role_arn='', targets=None):
if instance_ids is None:
instance_ids = []
if notification_config is None:
notification_config = {}
if parameters is None:
parameters = {}
if targets is None:
targets = []
self.error_count = 0
self.completed_count = len(instance_ids)