Yasuke/moto
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix: VpnGatewayId parameter casing in ec2:CreateVpnConnection request (#3401)

Browse Source 
Fixes #3397
This commit is contained in:
Brian Pandola 2020-10-27 00:41:01 -07:00 committed by GitHub
parent 403b06d9c5
commit c0a25bbd9a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 24 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
moto/ec2/responses/vpn_connections.py
View File

@ -7,7 +7,7 @@ class VPNConnections(BaseResponse):
def create_vpn_connection(self): def create_vpn_connection(self):
type = self._get_param("Type") type = self._get_param("Type")
cgw_id = self._get_param("CustomerGatewayId") cgw_id = self._get_param("CustomerGatewayId")
vgw_id = self._get_param("VPNGatewayId") vgw_id = self._get_param("VpnGatewayId")
static_routes = self._get_param("StaticRoutesOnly") static_routes = self._get_param("StaticRoutesOnly")
vpn_connection = self.ec2_backend.create_vpn_connection( vpn_connection = self.ec2_backend.create_vpn_connection(
type, cgw_id, vgw_id, static_routes_only=static_routes type, cgw_id, vgw_id, static_routes_only=static_routes

24
tests/test_ec2/test_vpn_connections.py
View File

@ -1,10 +1,11 @@
from __future__ import unicode_literals from __future__ import unicode_literals
import boto import boto
import boto3
from nose.tools import assert_raises from nose.tools import assert_raises
import sure # noqa import sure # noqa
from boto.exception import EC2ResponseError from boto.exception import EC2ResponseError
from moto import mock_ec2_deprecated from moto import mock_ec2_deprecated, mock_ec2
@mock_ec2_deprecated @mock_ec2_deprecated
@ -51,3 +52,24 @@ def test_describe_vpn_connections():
list_of_vpn_connections.should.have.length_of(2) list_of_vpn_connections.should.have.length_of(2)
list_of_vpn_connections = conn.get_all_vpn_connections(vpn.id) list_of_vpn_connections = conn.get_all_vpn_connections(vpn.id)
list_of_vpn_connections.should.have.length_of(1) list_of_vpn_connections.should.have.length_of(1)
@mock_ec2
def test_create_vpn_connection_with_vpn_gateway():
client = boto3.client("ec2", region_name="us-east-1")
vpn_gateway = client.create_vpn_gateway(Type="ipsec.1").get("VpnGateway", {})
customer_gateway = client.create_customer_gateway(
Type="ipsec.1", PublicIp="205.251.242.54", BgpAsn=65534,
).get("CustomerGateway", {})
vpn_connection = client.create_vpn_connection(
Type="ipsec.1",
VpnGatewayId=vpn_gateway["VpnGatewayId"],
CustomerGatewayId=customer_gateway["CustomerGatewayId"],
).get("VpnConnection", {})
vpn_connection["Type"].should.equal("ipsec.1")
vpn_connection["VpnGatewayId"].should.equal(vpn_gateway["VpnGatewayId"])
vpn_connection["CustomerGatewayId"].should.equal(
customer_gateway["CustomerGatewayId"]
)