Updates to FlowLogs and IMPLEMENTATION_COVERAGE (#3356)

* Replacing Unsuccessful class with tuple

* Updating coverage

IMPLEMENTATION_COVERAGE.md

@@ -2632,7 +2632,7 @@
 - [X] create_dhcp_options
 - [ ] create_egress_only_internet_gateway
 - [ ] create_fleet
-- [ ] create_flow_logs
+- [X] create_flow_logs
 - [ ] create_fpga_image
 - [X] create_image
 - [ ] create_instance_export_task
@@ -2682,7 +2682,7 @@
 - [ ] delete_dhcp_options
 - [ ] delete_egress_only_internet_gateway
 - [ ] delete_fleets
-- [ ] delete_flow_logs
+- [X] delete_flow_logs
 - [ ] delete_fpga_image
 - [X] delete_internet_gateway
 - [X] delete_key_pair
@@ -2753,7 +2753,7 @@
 - [ ] describe_fleet_history
 - [ ] describe_fleet_instances
 - [ ] describe_fleets
-- [ ] describe_flow_logs
+- [X] describe_flow_logs
 - [ ] describe_fpga_image_attribute
 - [ ] describe_fpga_images
 - [ ] describe_host_reservation_offerings
@@ -4235,7 +4235,7 @@
 - [X] remove_user_from_group
 - [ ] reset_service_specific_credential
 - [ ] resync_mfa_device
-- [ ] set_default_policy_version
+- [X] set_default_policy_version
 - [ ] set_security_token_service_preferences
 - [ ] simulate_custom_policy
 - [ ] simulate_principal_policy

moto/ec2/models.py

@@ -3532,15 +3532,6 @@ class SubnetBackend(object):
             raise InvalidParameterValueError(attr_name)
 
 
-class Unsuccessful(object):
-    def __init__(
-        self, resource_id, error_code, error_message,
-    ):
-        self.resource_id = resource_id
-        self.error_code = error_code
-        self.error_message = error_message
-
-
 class FlowLogs(TaggedEC2Resource, CloudFormationModel):
     def __init__(
         self,
@@ -3749,11 +3740,11 @@ class FlowLogsBackend(object):
                 try:
                     s3_backend.get_bucket(arn)
                 except MissingBucket:
+                    # Instead of creating FlowLog report
+                    # the unsuccessful status for the
+                    # given resource_id
                     unsuccessful.append(
-                        # Instead of creating FlowLog report
+                        (
-                        # the unsuccessful status for the
-                        # given resource_id
-                        Unsuccessful(
                             resource_id,
                             "400",
                             "LogDestination: {0} does not exist.".format(arn),

moto/ec2/responses/flow_logs.py

@@ -59,10 +59,10 @@ CREATE_FLOW_LOGS_RESPONSE = """
     {% for error in errors %}
       <item>
         <error>
-          <code>{{ error.error_code }}</code>
+          <code>{{ error.1 }}</code>
-          <message>{{ error.error_message }}</message>
+          <message>{{ error.2 }}</message>
         </error>
-        <resourceId>{{ error.resource_id }}</resourceId>
+        <resourceId>{{ error.0 }}</resourceId>
       </item>
     {% endfor %}
   </unsuccessful>