Yasuke/moto
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: cognito-idp: admin_create_user remove default attributes (#4070)

Browse Source 
* 4069: fix: cognito-idp: admin_create_user remove default attributes
This commit is contained in:
Alastair McCormack 2021-07-14 15:35:09 +01:00 committed by GitHub
parent eb6515cf50
commit cb53f86c24
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 14 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
moto/cognitoidp/models.py
View File

@ -658,10 +658,7 @@ class CognitoIdpBackend(BaseBackend):
UserStatus["FORCE_CHANGE_PASSWORD"], UserStatus["FORCE_CHANGE_PASSWORD"],
attributes, attributes,
) )
user.attributes.append({"Name": "sub", "Value": user.id})
user.attributes.append({"Name": "email_verified", "Value": True})
user.attributes.append({"Name": "name", "Value": ""})
user.attributes.append({"Name": "family_name", "Value": ""})
user_pool.users[user.username] = user user_pool.users[user.username] = user
return user return user

24
tests/test_cognitoidp/test_cognitoidp.py
View File

@ -1044,7 +1044,7 @@ def test_admin_create_user():
result["User"]["Username"].should.equal(username) result["User"]["Username"].should.equal(username)
result["User"]["UserStatus"].should.equal("FORCE_CHANGE_PASSWORD") result["User"]["UserStatus"].should.equal("FORCE_CHANGE_PASSWORD")
result["User"]["Attributes"].should.have.length_of(5) result["User"]["Attributes"].should.have.length_of(1)
def _verify_attribute(name, v): def _verify_attribute(name, v):
attr = [a for a in result["User"]["Attributes"] if a["Name"] == name] attr = [a for a in result["User"]["Attributes"] if a["Name"] == name]
@ -1052,9 +1052,6 @@ def test_admin_create_user():
attr[0]["Value"].should.equal(v) attr[0]["Value"].should.equal(v)
_verify_attribute("thing", value) _verify_attribute("thing", value)
_verify_attribute("name", "")
_verify_attribute("family_name", "")
_verify_attribute("email_verified", True)
result["User"]["Enabled"].should.equal(True) result["User"]["Enabled"].should.equal(True)
@ -1148,7 +1145,7 @@ def test_admin_get_user():
result = conn.admin_get_user(UserPoolId=user_pool_id, Username=username) result = conn.admin_get_user(UserPoolId=user_pool_id, Username=username)
result["Username"].should.equal(username) result["Username"].should.equal(username)
result["UserAttributes"].should.have.length_of(5) result["UserAttributes"].should.have.length_of(1)
@mock_cognitoidp @mock_cognitoidp
@ -1173,16 +1170,15 @@ def test_get_user():
outputs = authentication_flow(conn, "ADMIN_NO_SRP_AUTH") outputs = authentication_flow(conn, "ADMIN_NO_SRP_AUTH")
result = conn.get_user(AccessToken=outputs["access_token"]) result = conn.get_user(AccessToken=outputs["access_token"])
result["Username"].should.equal(outputs["username"]) result["Username"].should.equal(outputs["username"])
result["UserAttributes"].should.have.length_of(5) result["UserAttributes"].should.have.length_of(1)
def _verify_attribute(name, v): def _verify_attribute(name, v):
attr = [a for a in result["UserAttributes"] if a["Name"] == name] attr = [a for a in result["UserAttributes"] if a["Name"] == name]
attr.should.have.length_of(1) attr.should.have.length_of(1)
attr[0]["Value"].should.equal(v) attr[0]["Value"].should.equal(v)
_verify_attribute("name", "") for key, value in outputs["additional_fields"].items():
_verify_attribute("family_name", "") _verify_attribute(key, value)
_verify_attribute("email_verified", True)
@mock_cognitoidp @mock_cognitoidp
@ -2021,8 +2017,14 @@ def test_admin_set_user_password():
) )
result = conn.admin_get_user(UserPoolId=user_pool_id, Username=username) result = conn.admin_get_user(UserPoolId=user_pool_id, Username=username)
result["Username"].should.equal(username) result["Username"].should.equal(username)
result["UserAttributes"].should.have.length_of(5) result["UserAttributes"].should.have.length_of(1)
result["UserStatus"].should.equal("CONFIRMED")
def _verify_attribute(name, v):
attr = [a for a in result["UserAttributes"] if a["Name"] == name]
attr.should.have.length_of(1)
attr[0]["Value"].should.equal(v)
_verify_attribute("thing", value)
@mock_cognitoidp @mock_cognitoidp