From d2b0812edcdd5301e968796df4bdbe4d70f9eab8 Mon Sep 17 00:00:00 2001
From: acsbendi <acsbendi28@gmail.com>
Date: Sun, 30 Jun 2019 20:33:17 +0200
Subject: [PATCH] Added more tests.

---
 tests/test_iam/test_iam_policies.py | 144 ++++++++++++++++++++++++++++
 1 file changed, 144 insertions(+)

diff --git a/tests/test_iam/test_iam_policies.py b/tests/test_iam/test_iam_policies.py
index f1c53a7d0..1aeccf4f4 100644
--- a/tests/test_iam/test_iam_policies.py
+++ b/tests/test_iam/test_iam_policies.py
@@ -127,6 +127,18 @@ invalid_documents_test_cases = [
         },
         "error_message": 'Actions/Conditions must be prefaced by a vendor, e.g., iam, sdb, ec2, etc.'
     },
+    {
+        "document": {
+            "Version": "2012-10-17",
+            "Statement":
+                {
+                    "Effect": "Allow",
+                    "NotAction": "",
+                    "Resource": "arn:aws:s3:::example_bucket"
+                }
+        },
+        "error_message": 'Actions/Conditions must be prefaced by a vendor, e.g., iam, sdb, ec2, etc.'
+    },
     {
         "document": {
             "Version": "2012-10-17",
@@ -151,6 +163,24 @@ invalid_documents_test_cases = [
         },
         "error_message": 'Actions/Condition can contain only one colon.'
     },
+    {
+        "document": {
+            "Version": "2012-10-17",
+            "Statement": [
+                {
+                    "Effect": "Allow",
+                    "Action": "s3s:ListBucket",
+                    "Resource": "arn:aws:s3:::example_bucket"
+                },
+                {
+                    "Effect": "Allow",
+                    "Action": "s:3s:ListBucket",
+                    "Resource": "arn:aws:s3:::example_bucket"
+                }
+            ]
+        },
+        "error_message": 'Actions/Condition can contain only one colon.'
+    },
     {
         "document": {
             "Version": "2012-10-17",
@@ -162,6 +192,18 @@ invalid_documents_test_cases = [
         },
         "error_message": 'Resource invalid resource must be in ARN format or "*".'
     },
+    {
+        "document": {
+            "Version": "2012-10-17",
+            "Statement":
+                {
+                    "Effect": "Allow",
+                    "Action": "s:3:ListBucket",
+                    "Resource": "sdfsadf"
+                }
+        },
+        "error_message": 'Resource sdfsadf must be in ARN format or "*".'
+    },
     {
         "document": {
             "Version": "2012-10-17",
@@ -184,6 +226,42 @@ invalid_documents_test_cases = [
         },
         "error_message": 'Resource  must be in ARN format or "*".'
     },
+    {
+        "document": {
+            "Version": "2012-10-17",
+            "Statement":
+                {
+                    "Effect": "Allow",
+                    "NotAction": "s3s:ListBucket",
+                    "Resource": "a:bsdfdsafsad"
+                }
+        },
+        "error_message": 'Partition "bsdfdsafsad" is not valid for resource "arn:bsdfdsafsad:*:*:*:*".'
+    },
+    {
+        "document": {
+            "Version": "2012-10-17",
+            "Statement":
+                {
+                    "Effect": "Allow",
+                    "NotAction": "s3s:ListBucket",
+                    "Resource": "a:b:cadfsdf"
+                }
+        },
+        "error_message": 'Partition "b" is not valid for resource "arn:b:cadfsdf:*:*:*".'
+    },
+    {
+        "document": {
+            "Version": "2012-10-17",
+            "Statement":
+                {
+                    "Effect": "Allow",
+                    "NotAction": "s3s:ListBucket",
+                    "Resource": "a:b:c:d:e:f:g:h"
+                }
+        },
+        "error_message": 'Partition "b" is not valid for resource "arn:b:c:d:e:f:g:h".'
+    },
     {
         "document": {
             "Version": "2012-10-17",
@@ -340,6 +418,19 @@ invalid_documents_test_cases = [
         },
         "error_message": 'Syntax errors in policy.'
     },
+    {
+        "document": {
+            "Version": "2012-10-17",
+            "Statement":
+                {
+                    "Effect": "Allow",
+                    "NotAction": "s3:ListBucket",
+                    "Resource": "arn:aws:s3:::example_bucket",
+                    "NotResource": []
+                }
+        },
+        "error_message": 'Syntax errors in policy.'
+    },
     {
         "document": {
             "Version": "2012-10-17",
@@ -351,6 +442,19 @@ invalid_documents_test_cases = [
         },
         "error_message": 'Syntax errors in policy.'
     },
+    {
+        "document": {
+            "Version": "2012-10-17",
+            "Statement":
+                {
+                    "Effect": "Allow",
+                    "NotAction": "s3s:ListBucket",
+                    "Action": [],
+                    "Resource": "arn:aws:s3:::example_bucket"
+                }
+        },
+        "error_message": 'Syntax errors in policy.'
+    },
     {
         "document": {
             "Version": "2012-10-17",
@@ -546,6 +650,23 @@ invalid_documents_test_cases = [
         },
         "error_message": 'Statement IDs (SID) in a single policy must be unique.'
     },
+    {
+        "document": {
+            "Statement": [
+                {
+                    "Sid": "sdf",
+                    "Effect": "Allow",
+                    "Action": "s3:ListBucket",
+                    "Resource": "arn:aws:s3:::example_bucket"
+                },
+                {
+                    "Sid": "sdf",
+                    "Effect": "Allow"
+                }
+            ]
+        },
+        "error_message": 'Policy document must be version 2012-10-17 or greater.'
+    },
     {
         "document": {
             "Version": "2012-10-17",
@@ -622,6 +743,29 @@ invalid_documents_test_cases = [
                 }
         },
         "error_message": 'The policy failed legacy parsing'
+    },
+    {
+        "document": {
+            "Version": "2012-10-17",
+            "Statement":
+                {
+                    "Effect": "Allow",
+                    "NotAction": "s3:ListBucket",
+                    "Resource": "arn:aws::::example_bucket"
+                }
+        },
+        "error_message": 'The policy failed legacy parsing'
+    },
+    {
+        "document": {
+            "Version": "2012-10-17",
+            "Statement":
+                {
+                    "Effect": "allow",
+                    "Resource": "arn:aws:s3:us-east-1::example_bucket"
+                }
+        },
+        "error_message": 'The policy failed legacy parsing'
     }
 ]  # TODO add more tests