Fix update for application autoscaling register target (#3423)

moto/applicationautoscaling/models.py

@@ -98,7 +98,7 @@ class ApplicationAutoscalingBackend(BaseBackend):
             _ = self._ecs_service_exists_for_target(r_id)
         if self._scalable_target_exists(r_id, dimension):
             target = self.targets[dimension][r_id]
-            target.update(kwargs)
+            target.update(**kwargs)
         else:
             target = FakeScalableTarget(self, namespace, r_id, dimension, **kwargs)
             self._add_scalable_target(target)
@@ -197,6 +197,8 @@ class FakeScalableTarget(BaseModel):
             self.min_capacity = kwargs["min_capacity"]
         if kwargs["max_capacity"] is not None:
             self.max_capacity = kwargs["max_capacity"]
+        if kwargs["suspended_state"] is not None:
+            self.suspended_state = kwargs["suspended_state"]
 
 
 applicationautoscaling_backends = {}

tests/test_applicationautoscaling/test_applicationautoscaling.py

@@ -260,3 +260,47 @@ def test_register_scalable_target_resource_id_variations():
         t.should.have.key("ResourceId").which.should.equal(resource_id)
         t.should.have.key("ScalableDimension").which.should.equal(scalable_dimension)
         t.should.have.key("CreationTime").which.should.be.a("datetime.datetime")
+
+
+@mock_ecs
+@mock_applicationautoscaling
+def test_register_scalable_target_updates_existing_target():
+    ecs = boto3.client("ecs", region_name=DEFAULT_REGION)
+    _create_ecs_defaults(ecs)
+    client = boto3.client("application-autoscaling", region_name=DEFAULT_REGION)
+    register_scalable_target(client)
+
+    updated_min_capacity = 3
+    updated_max_capacity = 10
+    updated_suspended_state = {
+        "DynamicScalingInSuspended": False,
+        "DynamicScalingOutSuspended": False,
+        "ScheduledScalingSuspended": False,
+    }
+
+    client.register_scalable_target(
+        ServiceNamespace=DEFAULT_SERVICE_NAMESPACE,
+        ResourceId=DEFAULT_RESOURCE_ID,
+        ScalableDimension=DEFAULT_SCALABLE_DIMENSION,
+        MinCapacity=updated_min_capacity,
+        MaxCapacity=updated_max_capacity,
+        SuspendedState=updated_suspended_state,
+    )
+    response = client.describe_scalable_targets(
+        ServiceNamespace=DEFAULT_SERVICE_NAMESPACE
+    )
+
+    len(response["ScalableTargets"]).should.equal(1)
+    t = response["ScalableTargets"][0]
+    t.should.have.key("MinCapacity").which.should.equal(updated_min_capacity)
+    t.should.have.key("MaxCapacity").which.should.equal(updated_max_capacity)
+    t.should.have.key("SuspendedState")
+    t["SuspendedState"]["DynamicScalingInSuspended"].should.equal(
+        updated_suspended_state["DynamicScalingInSuspended"]
+    )
+    t["SuspendedState"]["DynamicScalingOutSuspended"].should.equal(
+        updated_suspended_state["DynamicScalingOutSuspended"]
+    )
+    t["SuspendedState"]["ScheduledScalingSuspended"].should.equal(
+        updated_suspended_state["ScheduledScalingSuspended"]
+    )