From 386ac94abe8e2f97893bf8d0fd40827fdc1d9d6e Mon Sep 17 00:00:00 2001
From: Brian Rower <Brian.Rower@gmail.com>
Date: Mon, 11 Sep 2017 12:06:24 -0700
Subject: [PATCH] Allow doing an ADD update of a string set

Fix test
---
 moto/dynamodb2/models.py                      |  6 ++++
 .../test_dynamodb_table_with_range_key.py     | 30 +++++++++++++++++++
 2 files changed, 36 insertions(+)

diff --git a/moto/dynamodb2/models.py b/moto/dynamodb2/models.py
index 7590ee1e1..9bb0ee441 100644
--- a/moto/dynamodb2/models.py
+++ b/moto/dynamodb2/models.py
@@ -171,6 +171,12 @@ class Item(BaseModel):
                         decimal.Decimal(existing.value) +
                         decimal.Decimal(new_value)
                     )})
+                elif set(update_action['Value'].keys()) == set(['SS']):
+                    existing = self.attrs.get(attribute_name, DynamoType({"SS": {}}))
+                    new_set = set(existing.value).union(set(new_value))
+                    self.attrs[attribute_name] = DynamoType({
+                        "SS": list(new_set)
+                    })
                 else:
                     # TODO: implement other data types
                     raise NotImplementedError(
diff --git a/tests/test_dynamodb2/test_dynamodb_table_with_range_key.py b/tests/test_dynamodb2/test_dynamodb_table_with_range_key.py
index e4a586cbb..93dc5b3ef 100644
--- a/tests/test_dynamodb2/test_dynamodb_table_with_range_key.py
+++ b/tests/test_dynamodb2/test_dynamodb_table_with_range_key.py
@@ -1306,6 +1306,36 @@ def test_update_item_add_value():
     })
 
 
+@mock_dynamodb2
+def test_update_item_add_value_string_set():
+    table = _create_table_with_range_key()
+
+    table.put_item(Item={
+        'forum_name': 'the-key',
+        'subject': '123',
+        'string_set': set(['str1', 'str2']),
+    })
+
+    item_key = {'forum_name': 'the-key', 'subject': '123'}
+    table.update_item(
+        Key=item_key,
+        AttributeUpdates={
+            'string_set': {
+                'Action': u'ADD',
+                'Value': set(['str3']),
+            },
+        },
+    )
+
+    returned_item = dict((k, str(v) if isinstance(v, Decimal) else v)
+                         for k, v in table.get_item(Key=item_key)['Item'].items())
+    dict(returned_item).should.equal({
+        'string_set': set(['str1', 'str2', 'str3']),
+        'forum_name': 'the-key',
+        'subject': '123',
+    })
+
+
 @mock_dynamodb2
 def test_update_item_add_value_does_not_exist_is_created():
     table = _create_table_with_range_key()