From da39d2103c8a2bed583f170df0b7854661cc4aa8 Mon Sep 17 00:00:00 2001 From: Bert Blommers Date: Wed, 26 Apr 2023 10:56:08 +0000 Subject: [PATCH] Remove tests incompatible with werkzeug 2.3.0 (#6257) --- tests/test_core/test_account_id_resolution.py | 1 - tests/test_s3/test_server.py | 6 +++++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/tests/test_core/test_account_id_resolution.py b/tests/test_core/test_account_id_resolution.py index b4df22532..d5d5b56bd 100644 --- a/tests/test_core/test_account_id_resolution.py +++ b/tests/test_core/test_account_id_resolution.py @@ -57,7 +57,6 @@ class TestAccountIdResolution: headers = { "Authorization": "AWS4-HMAC-SHA256 Credential=abcd/20010101/us-east-2/sts/aws4_request, SignedHeaders=host;x-amz-content-sha256;x-amz-date, Signature=...", "Content-Length": f"{len(data)}", - "Content-Type": "application/x-www-form-urlencoded", } headers.update(extra_headers or {}) return requests.post(f"{BASE_URL}", headers=headers, data=data) diff --git a/tests/test_s3/test_server.py b/tests/test_s3/test_server.py index a971b4ec3..3f60fb831 100644 --- a/tests/test_s3/test_server.py +++ b/tests/test_s3/test_server.py @@ -36,8 +36,12 @@ def test_s3_server_get(): res.data.should.contain(b"ListAllMyBucketsResult") -@pytest.mark.parametrize("key_name", ["bar_baz", "bar+baz", "baz bar"]) +@pytest.mark.parametrize("key_name", ["bar_baz", "baz bar"]) def test_s3_server_bucket_create(key_name): + # Very similar test in test_s3.py::test_get_object_versions_with_prefix + # That test also includes a key containing a +, such as 'baz+bar' + # We cannot test that example here, because Werkzeug (as of 2.3.0) will helpfully normalize that to `baz bar` + # TODO: re-enable this key-name if/when we ever replace Werkzeug test_client = authenticated_client() res = test_client.put("/", "http://foobaz.localhost:5000/")