Yasuke/moto
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Secretsmanager: fix(add-secret): SecretString can be None (#5672)

Browse Source
This commit is contained in:
Pepe Fagoaga 2022-11-18 22:18:47 +01:00 committed by GitHub
parent 5760e5fe48
commit dfd45d80ab
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 22 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
moto/secretsmanager/models.py
View File

@ -522,9 +522,14 @@ class SecretsManagerBackend(BaseBackend):
# We add the new secret version as "pending". The previous version remains # We add the new secret version as "pending". The previous version remains
# as "current" for now. Once we've passed the new secret through the lambda # as "current" for now. Once we've passed the new secret through the lambda
# rotation function (if provided) we can then update the status to "current". # rotation function (if provided) we can then update the status to "current".
old_secret_version_secret_string = (
old_secret_version["secret_string"]
if "secret_string" in old_secret_version
else None
)
self._add_secret( self._add_secret(
secret_id, secret_id,
old_secret_version["secret_string"], old_secret_version_secret_string,
description=secret.description, description=secret.description,
tags=secret.tags, tags=secret.tags,
version_id=new_version_id, version_id=new_version_id,

16
tests/test_secretsmanager/test_secretsmanager.py
View File

@ -644,6 +644,22 @@ def test_rotate_secret():
assert describe_secret["Description"] == "foodescription" assert describe_secret["Description"] == "foodescription"
@mock_secretsmanager
def test_rotate_secret_without_secretstring():
conn = boto3.client("secretsmanager", region_name="us-west-2")
conn.create_secret(Name=DEFAULT_SECRET_NAME, Description="foodescription")
rotated_secret = conn.rotate_secret(SecretId=DEFAULT_SECRET_NAME)
assert rotated_secret
assert rotated_secret["ARN"] == rotated_secret["ARN"]
assert rotated_secret["Name"] == DEFAULT_SECRET_NAME
assert rotated_secret["VersionId"] == rotated_secret["VersionId"]
describe_secret = conn.describe_secret(SecretId=DEFAULT_SECRET_NAME)
assert describe_secret["Description"] == "foodescription"
@mock_secretsmanager @mock_secretsmanager
def test_rotate_secret_enable_rotation(): def test_rotate_secret_enable_rotation():
conn = boto3.client("secretsmanager", region_name="us-west-2") conn = boto3.client("secretsmanager", region_name="us-west-2")