From dfe01dad170700152ae58b291e7361456b02754b Mon Sep 17 00:00:00 2001 From: Bert Blommers Date: Thu, 11 Nov 2021 10:51:09 -0100 Subject: [PATCH] S3 - Remove double quotes on ETag after copy (#4561) --- moto/s3/models.py | 1 - tests/test_s3/test_s3.py | 3 ++- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/moto/s3/models.py b/moto/s3/models.py index 7b40d15d0..44aa2493f 100644 --- a/moto/s3/models.py +++ b/moto/s3/models.py @@ -2016,7 +2016,6 @@ class S3Backend(BaseBackend): key_name=dest_key_name, value=key.value, storage=storage or key.storage_class, - etag=key.etag, multipart=key.multipart, encryption=key.encryption, kms_key_id=key.kms_key_id, diff --git a/tests/test_s3/test_s3.py b/tests/test_s3/test_s3.py index fdf517a47..c75966ed1 100644 --- a/tests/test_s3/test_s3.py +++ b/tests/test_s3/test_s3.py @@ -1049,7 +1049,7 @@ def test_copy_key_replace_metadata_boto3(): s3.create_bucket(Bucket="foobar") key = s3.Object("foobar", "the-key") - key.put(Body=b"some value", Metadata={"md": "Metadatastring"}) + initial = key.put(Body=b"some value", Metadata={"md": "Metadatastring"}) client.copy_object( Bucket="foobar", @@ -1061,6 +1061,7 @@ def test_copy_key_replace_metadata_boto3(): resp = client.get_object(Bucket="foobar", Key="new-key") resp["Metadata"].should.equal({"momd": "Mometadatastring"}) + resp["ETag"].should.equal(initial["ETag"]) # Has boto3 equivalent