Yasuke/moto
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Scheduler: Fix update_schedule raising ResourceNotFound errors when using schedule groups (#6269)

Browse Source
This commit is contained in:
Álvaro Torres Cogollo 2023-04-29 21:27:43 +02:00 committed by GitHub
parent e2d3582471
commit e5e1521523
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 15 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
moto/scheduler/responses.py
View File

@ -60,7 +60,7 @@ class EventBridgeSchedulerResponse(BaseResponse):
return "{}" return "{}"
def update_schedule(self) -> str: def update_schedule(self) -> str:
group_name = self._get_param("groupName") group_name = self._get_param("GroupName")
name = self.uri.split("?")[0].split("/")[-1] name = self.uri.split("?")[0].split("/")[-1]
description = self._get_param("Description") description = self._get_param("Description")
end_date = self._get_param("EndDate") end_date = self._get_param("EndDate")

16
tests/test_scheduler/test_scheduler.py
View File

@ -81,11 +81,22 @@ def test_create_get_delete__in_different_group():
assert err["Code"] == "ResourceNotFoundException" assert err["Code"] == "ResourceNotFoundException"
@pytest.mark.parametrize(
"extra_kwargs",
[
({}),
({"GroupName": "some-group"}),
],
ids=["without_group", "with_group"],
)
@mock_scheduler @mock_scheduler
def test_update_schedule(): def test_update_schedule(extra_kwargs):
client = boto3.client("scheduler", region_name="eu-west-1") client = boto3.client("scheduler", region_name="eu-west-1")
client.create_schedule_group(Name="some-group")
client.create_schedule( client.create_schedule(
**extra_kwargs,
Name="my-schedule", Name="my-schedule",
ScheduleExpression="some cron", ScheduleExpression="some cron",
FlexibleTimeWindow={ FlexibleTimeWindow={
@ -99,6 +110,7 @@ def test_update_schedule():
) )
client.update_schedule( client.update_schedule(
**extra_kwargs,
Name="my-schedule", Name="my-schedule",
Description="new desc", Description="new desc",
ScheduleExpression="new cron", ScheduleExpression="new cron",
@ -113,7 +125,7 @@ def test_update_schedule():
}, },
) )
schedule = client.get_schedule(Name="my-schedule") schedule = client.get_schedule(**extra_kwargs, Name="my-schedule")
assert schedule["Description"] == "new desc" assert schedule["Description"] == "new desc"
assert schedule["ScheduleExpression"] == "new cron" assert schedule["ScheduleExpression"] == "new cron"
assert schedule["State"] == "DISABLED" assert schedule["State"] == "DISABLED"