Yasuke/moto
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix: eventName for a deleted record should be REMOVE instead of DELETE (#3431)

Browse Source 
Verified API documentation[1] against the real AWS backend.

[1]: https://docs.aws.amazon.com/amazondynamodb/latest/APIReference/API_streams_Record.html#DDB-Type-streams_Record-eventName

Fixes #3400
This commit is contained in:
Brian Pandola 2020-11-02 09:21:09 -08:00 committed by GitHub
parent f57a77451c
commit f584e16ab9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
moto/dynamodb2/models/__init__.py
View File

@ -245,7 +245,7 @@ class StreamShard(BaseModel):
if old is None: if old is None:
event_name = "INSERT" event_name = "INSERT"
elif new is None: elif new is None:
event_name = "DELETE" event_name = "REMOVE"
else: else:
event_name = "MODIFY" event_name = "MODIFY"
seq = len(self.items) + self.starting_sequence_number seq = len(self.items) + self.starting_sequence_number

6
tests/test_dynamodbstreams/test_dynamodbstreams.py
View File

@ -155,7 +155,7 @@ class TestCore:
assert len(resp["Records"]) == 3 assert len(resp["Records"]) == 3
assert resp["Records"][0]["eventName"] == "INSERT" assert resp["Records"][0]["eventName"] == "INSERT"
assert resp["Records"][1]["eventName"] == "MODIFY" assert resp["Records"][1]["eventName"] == "MODIFY"
assert resp["Records"][2]["eventName"] == "DELETE" assert resp["Records"][2]["eventName"] == "REMOVE"
sequence_number_modify = resp["Records"][1]["dynamodb"]["SequenceNumber"] sequence_number_modify = resp["Records"][1]["dynamodb"]["SequenceNumber"]
@ -175,7 +175,7 @@ class TestCore:
resp = conn.get_records(ShardIterator=iterator_id) resp = conn.get_records(ShardIterator=iterator_id)
assert len(resp["Records"]) == 2 assert len(resp["Records"]) == 2
assert resp["Records"][0]["eventName"] == "MODIFY" assert resp["Records"][0]["eventName"] == "MODIFY"
assert resp["Records"][1]["eventName"] == "DELETE" assert resp["Records"][1]["eventName"] == "REMOVE"
# check that if we get the shard iterator AFTER_SEQUENCE_NUMBER will get the DELETE event # check that if we get the shard iterator AFTER_SEQUENCE_NUMBER will get the DELETE event
resp = conn.get_shard_iterator( resp = conn.get_shard_iterator(
@ -187,7 +187,7 @@ class TestCore:
iterator_id = resp["ShardIterator"] iterator_id = resp["ShardIterator"]
resp = conn.get_records(ShardIterator=iterator_id) resp = conn.get_records(ShardIterator=iterator_id)
assert len(resp["Records"]) == 1 assert len(resp["Records"]) == 1
assert resp["Records"][0]["eventName"] == "DELETE" assert resp["Records"][0]["eventName"] == "REMOVE"
class TestEdges: class TestEdges: